Issue: Cannot remove deleted pages from book

Issue Tools
- View Changes

November 25, 2016 8:36 AM

Alfa1

Distinguished Member

Cannot remove deleted pages from book

Its not possible to remove deleted pages from a book.

Issue Details

Issue Number 4811

Issue Type Bug

Project VaultWiki 4.x Series

Category Books / Chapters

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.15

Fixed Version 4.0.16

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

November 25, 2016 11:38 AM
pegasus

VaultWiki Team
I suspect you mean that, when a book-chapter has been soft-deleted as a page, going to Options > Add to Book produces a permissions error. As far as I can tell, it is still possible to remove the chapter from the book using inline moderation from the book's table of contents.

This is due to old VaultWiki-3-style code that was used prior to 4.0.1 PL 3 and apparently is still used as the first line of defense when performing assignments via dedicated tab. This is a problem, because since that time, it is now possible to have book push/unpush permissions without also having permission to edit the page. In vault/core/controller/ui/page/vw.php, find:

Code:

if ($this->has_permission('edit')) { $this->assign($type); }

Replace with:

Code:

if ($this->has_permission($this->action)) { $this->assign($type); }
Reply

+ Reply

All times are GMT -4. The time now is 4:46 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Cannot remove deleted pages from book

Issue Tools