Issue: Alert bug after deleting wiki pages

Issue Tools
- View Changes

November 24, 2016 5:44 PM
Alfa1

Distinguished Member
Alert bug after deleting wiki pages

I soft deleted 3 articles from an area. Then I received 2 alerts:

Wiki_starter_name created a page page_title in wiki

There are several issues with this:

No pages were created. The alert is in error
3 pages were deleted, but there are 2 alerts
the pages were not in the area 'wiki' but in a sub-area

Issue Details

Issue Number 4806

Issue Type Bug

Project VaultWiki 4.x Series

Category User Alerts / Likes

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.15

Fixed Version 4.0.16

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

December 5, 2016 3:23 PM

pegasus

VaultWiki Team

#3 is probably occurring because you are not watching the sub-area but you are watching "wiki". If so, the behavior is correct because the alert must link back to the watched node so you can un-watch if desired.

I'm still looking into the other points.

Reply
December 5, 2016 3:26 PM

Alfa1

Distinguished Member

The same happens if I unapprove a wiki article.

Reply
December 6, 2016 3:22 PM
pegasus

VaultWiki Team
In vault/core/controller/dm/page/vw.php, find:

Code:

if ($updown AND !$this->instance->get_info('is_automated'))

Replace with:

Code:

if ($updown > 0 AND !$this->instance->get_info('is_automated'))

This wraps the ::notify_subscribed() method. $updown is negative when visible content deleted or unapproved. Failure to check whether the value was positive had led to instant subscription notifications being sent. Since subscriptions are only expected to be sent due to a page when the page is created or approved, the notification used the 'create' language.

It is likely you only received 2 alerts because the 3rd item was still awaiting moderation when it was deleted.

So the real bug was not 1, 2, or 3, but rather that subscriber notifications were triggered by this action.

A similar issue occurs when a new discussion is deleted/unapproved on a wiki page. In vault/core/controller/dm/discussion/vw.php, find:

Code:

else { $this->notify_subscribed(); }

Replace with:

Code:

else if ($updown > 0) { $this->notify_subscribed(); }

And when a new version of an existing attachment is deleted/unapproved. In vault/core/controller/dm/attach/edit/vw.php, find:

Code:

if ($updown AND vw_Hard_Core::model('Settings')->get('vw_sub_edit')) { $this->notify_subscribed(); }

Replace with:

Code:

if ($updown > 0 AND vw_Hard_Core::model('Settings')->get('vw_sub_edit')) { $this->notify_subscribed(); }

Going though, I've noticed some other issues with subscriptions, such as existing pages being added as new entries in books, categories, etc possibly not triggering notifications in the book, category, etc.
Reply

+ Reply

All times are GMT -4. The time now is 4:45 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Alert bug after deleting wiki pages

Issue Tools