Issue: Undefined index: height - library/NixFifty

Issue Tools
- View Changes

September 3, 2016 3:03 PM

Alfa1

Distinguished Member

Undefined index: height - library/NixFifty

Editing the main wiki page leads to an error. Seems a conflict with nixfifty tickets. (PixelExit)

Code:

ErrorException: Undefined index: height - library/NixFifty/Tickets/Listener.php:143 
Generated By: Alfa, 1 minute ago

Stack Trace
#0 /library/NixFifty/Tickets/Listener.php(143): XenForo_Application::handlePhpError(8, 'Undefined index...', '/home/...', 143, Array)
#1 /library/XenForo/CodeEvent.php(90): NixFifty_Tickets_Listener::editorSetup(Object(XenForo_ViewPublic_Base), 'message', '', Array, true)
#2 /library/vw/XenForo/ViewPublic/Helper/Editor.php(141): XenForo_CodeEvent::fire('editor_setup', Array)
#3 /vault/core/view/editor/xf.php(161): vw_XenForo_ViewPublic_Helper_Editor::getEditorTemplate(Object(XenForo_ViewPublic_Base), 'message', '', Array)
#4 /vault/core/view/ui/edit/page/vw.php(81): vw_Editor_View_XF->get_editor('fe', Array, NULL)
#5 /vault/core/view/ui/edit/vw.php(105): vw_UI_Edit_Page_View->get_fields(Object(vw_UI_Page_Controller_XF))
#6 /vault/core/controller/ui/edit/vw.php(707): vw_UI_Edit_View->edit(Object(vw_UI_Page_Controller_XF))
#7 /vault/core/controller/ui/page/vw.php(319): vw_UI_Edit_Controller->edit(Object(vw_UI_Page_Controller_XF))
#8 /vault/core/controller/ui/page/vw.php(141): vw_UI_Page_Controller->edit(false)
#9 /vault/core/controller/ui/page/xf.php(58): vw_UI_Page_Controller->execute()
#10 /vault/core/controller/ui/stack/vw.php(231): vw_UI_Page_Controller_XF->execute()
#11 /library/vw/XenForo/ControllerPublic/Wiki.php(68): vw_UI_Stack_Controller->execute()
#12 /library/XenForo/FrontController.php(351): vw_XenForo_ControllerPublic_Wiki->actionIndex()
#13 /library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#14 /index.php(13): XenForo_FrontController->run()
#15 {main}
Request State
array(3) {
  ["url"] => string(53) "https://site.com/wiki/?do=edit"
  ["_GET"] => array(1) {
    ["do"] => string(4) "edit"
  }
  ["_POST"] => array(0) {
  }
}

Issue Details

Issue Number 4712

Issue Type Bug

Project VaultWiki 4.x Series

Category Editing Pages

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.0.13

Fixed Version 4.0.14

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 4, 2016 10:17 AM

pegasus

VaultWiki Team

Thanks, our editor helper was written back when XenForo was still 1.1.0, so it was missing some more recent editor options default values that were easy to miss.

Fixed in the next release. The helper has been slightly reworked to make sure expected editor options are still available in editor_setup, even if VaultWiki intends to disable those keys for wiki content. This should allow add-ons to modify those keys without first checking for a wiki editor context. Along those lines, $editorOptions['isWikiEditor'] has been added to make it easier for add-ons to tell.

Reply
September 4, 2016 12:17 PM

Alfa1

Distinguished Member

Could you release an a patch for this?
I am in the middle of a pre-release demo before final migration.

Reply
September 4, 2016 1:36 PM
pegasus

VaultWiki Team
This patch won't do anything except make the error stop appearing in the logs. Whatever changes NixFifty applies to the 'height' index will not be applied because that requires a refactoring of the helper class, which is too complex to post here.

In library/vw/XenForo/ViewPublic/Helper/Editor.php, find:

Code:

$saveWysiwyg = $showWysiwyg;

After it, add:

Code:

if (!isset($editorOptions['height'])) $editorOptions['height'] = $height;
Reply
September 4, 2016 7:54 PM

Alfa1

Distinguished Member

Is it possible to releasing a next build with a refactored helper class in it?

Reply
September 4, 2016 9:26 PM

pegasus

VaultWiki Team

We do not release same-version builds unless there is a breaking change (such as a fatal or database error in major functionality). More, we do not release same-version builds on top of Patch Level releases. Once a Patch Level occurs, all existing releases are locked.

We are only a few days away from the next scheduled release anyway.

Regardless, I am not sure why it would be important for NixFifty to alter the height of the wiki's editor. I think it would only want to affect the editor height for tickets. As you noted, this error only occurs on specific wiki pages. That is because the wiki editor uses a custom helper that omitted a default value for the height index. So I don't think you need to worry about having a refactored helper class immediately because it would have no effect on your UX either way.

Reply
September 5, 2016 6:19 AM

Alfa1

Distinguished Member

Thanks for explaining. I can wait a few days for the next release.

Reply
September 10, 2016 6:09 PM

Alfa1

Distinguished Member

NIxFifty does not alter the editor height. it only injects some response code in to the editor.

Reply
September 11, 2016 5:56 AM

Alfa1

Distinguished Member

Related bug report: https://pixelexit.com/threads/undefi...-php-143.4224/
I can only bring NixFifty Tickets back online after the issue is fixed. The fatal error kills the entire site.

Reply
September 11, 2016 2:20 PM

pegasus

VaultWiki Team

undefined index is not a fatal error. It is an E_NOTICE level error and should only be appearing in your logs unless you have debug mode turned on (which you would not in production).

The link you posted points to a private forum, probably for paying customers only. If there is new information in that link, please quote it here.

Reply

+ Reply

All times are GMT -4. The time now is 4:47 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Undefined index: height - library/NixFifty

Issue Tools