Issue: A lot of whitespace inserted before insights bbcode

Issue Tools
- View Changes

March 4, 2016 4:13 PM

Alfa1

Distinguished Member

A lot of whitespace inserted before insights bbcode

Everywhere a google trends / insights bb code is used, a large amount of white space is inserted. This was not the case on VW3.

Issue Details

Issue Number 4572

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Not a Bug

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.0.9

Fixed Version (none)

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 5, 2016 11:31 AM

pegasus

VaultWiki Team

Please submit example source code that results in unwanted white-space.

Reply

March 5, 2016 11:39 AM

Alfa1

Distinguished Member

The paragraph only contains a bbcode:
[insights]VARNAME[/insights]

From the bb code manager:

Code:

<script type="text/javascript" src="//www.google.com/trends/embed.js?hl=en-US&q={param}&content=1&cid=TIMESERIES_GRAPH_0&export=5&w=600&h=350"></script>

<script type="text/javascript" src="//www.google.com/trends/embed.js?hl=en-US&q={param}&content=1&cid=GEO_MAP_0_0&export=5&w=500&h=400"></script>

March 7, 2016 9:57 AM

pegasus

VaultWiki Team

Was the insights BB-Code inside a TABLE? When I asked for sample code, I was looking for an overall context that would show me how it would interact with other BB-Codes.

For example, if you were using vBulletin TABLE syntax, with line breaks between TR or TD, but VaultWiki TABLE was actually set-up to parse instead, then the contents of the table would be pushed down because TR/TD don't mean anything to VaultWiki's BB-Code, so the line breaks are expected to be intended literally.

This is just one example, but that's why it's important to send the full source code when BB-Code isn't looking right.

Reply
March 7, 2016 1:28 PM

Alfa1

Distinguished Member

The paragraph only had the above bbcode and no other content.
The article had a headline bbcode code and under that the insights bbode.Under that another headline.

Reply
March 30, 2016 11:22 AM

pegasus

VaultWiki Team

See: https://www.vaultwiki.org/demo/Group...d-Have-Guessed
There is no extra space above the first insights block.

By default, the insights output has a fixed height of 350 for the first block, and 400 for the second block, according to the settings in your BB-Code replacement. When there are not enough results, the height simply doesn't get filled completely. If you enter garbage in the tag, Google doesn't bother to send a response, and you have 750px of whitespace.

This is Not a Bug in VaultWiki.

Reply
March 30, 2016 12:14 PM

Alfa1

Distinguished Member

The example doesn't load for me.

Reply
March 30, 2016 2:14 PM

pegasus

VaultWiki Team

The space between/below the insights blocks occurs because of the hard-coded height in the script tag. So even if there's not enough content, it uses up the height.

Reply

April 4, 2017 1:47 PM

Alfa1

Distinguished Member

I cant get Google Trends bbcode to load in Vaultwiki anymore. Do you have any idea why?

I also tried this:

Code:

  <script type="text/javascript" src="https://ssl.gstatic.com/trends_nrtr/962_RC10/embed_loader.js"></script>
  <script type="text/javascript">
    trends.embed.renderExploreWidget("TIMESERIES", {"comparisonItem":[{"keyword":"{text}","geo":"","time":"today 5-y"}],"category":0,"property":""}, {"exploreQuery":"q={text}","guestPath":"https://trends.google.com:443/trends/embed/"});
  </script>

  <script type="text/javascript" src="https://ssl.gstatic.com/trends_nrtr/962_RC10/embed_loader.js"></script>
  <script type="text/javascript">
    trends.embed.renderExploreWidget("GEO_MAP", {"comparisonItem":[{"keyword":"{text}","geo":"","time":"today 5-y"}],"category":0,"property":""}, {"exploreQuery":"q={text}","guestPath":"https://trends.google.com:443/trends/embed/"});
  </script>

April 5, 2017 11:25 AM

pegasus

VaultWiki Team

Using this replacement, an INSIGHTS BB-Code works as expected on the XF demo: https://www.vaultwiki.org/xf-wiki/in...d-Have-Guessed
If your BB-Code is actually enabled and does not have parsing turned off in the Wiki-Related Options, I would not be able to tell you why it's not working on your site without seeing your parser internals. It might be related to another add-on you have installed.

Reply

+ Reply

All times are GMT -4. The time now is 10:48 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: A lot of whitespace inserted before insights bbcode

Issue Tools