Issue: Vaultwiki breaks sitemap generation process, caused server to run out of disk space and crash

Issue Tools
- View Changes

November 10, 2015 12:40 PM

clackey

New Member

Vaultwiki breaks sitemap generation process, caused server to run out of disk space and crash

Was woken up very early this morning by my alerts going off that our sites were down.

Eventually tracked it down to Vaultwiki breaking sitemap generation during the tags step. When it took down the server, it'd created 43GB of temp sitemap files, when that's normally < 10MB. It would have continued to try to generate the temp files except it ran out of space. The sitemap log shows it created 8,202 files tracking 410+ million urls on a site that has nowhere near that.

I just now implemented the fix for the 'Undefined Index: user' issue, hoping that would fix this as well but it didn't...

When I run build sitemap with Vaultwiki disabled, it works perfectly. But as soon as VW enabled, it just perpetually churns out temp files.

I've disabled automatic sitemap generation for now. Let me know the fix and I'll apply... I'm kind of surprised no one else has hit this yet.

Issue Details

Issue Number 4444

Issue Type Bug

Project VaultWiki 4.x Series

Category Permissions / Security

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.7

Fixed Version 4.0.7

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

November 11, 2015 8:20 AM
pegasus

VaultWiki Team
In library/vw/XenForo/Model/Tag.php, find:

Code:

$tags["$key"] = $tag;

Replace with:

Code:

$tags["$tag_id"] = $tag;

I will issue a patch shortly. This was incorrectly resolving to $tags['tag_id'] rather than $tags[actual_tag_id]
Reply
November 11, 2015 5:05 PM

clackey

New Member

Thanks. That fixed it.

Also, in the future do you mind including line numbers when you list the code to replace?
I'm always a bit leery of accidentally swapping the wrong bit of code...

Reply
November 11, 2015 9:05 PM

pegasus

VaultWiki Team

Everyone's line numbers are different, unfortunately.

Reply

+ Reply

All times are GMT -4. The time now is 10:45 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Vaultwiki breaks sitemap generation process, caused server to run out of disk space and crash

Issue Tools