The offending code that originally caused this:
Code:
vw_XenForo_Model::fetch('XenForo_Model_Template')->deleteTemplatesForAddOn('vaultwiki');
Is no longer present in
vault/core/controller/install/common/xf.php
There is no other code that would result in any unwanted loss of template data.
If you are using an Opcode Cache like Zend Opcache, Xcache, etc, make sure that you always empty it before performing an upgrade, or you risk running the old code from the last version even though you already uploaded new files. Trusting the server to compare if a file is new or updated based on a timestamp is not reliable as mentioned in the manual page for
Updating the VaultWiki Scripts on Your Web Server:
Make sure that you choose to overwrite ALL existing VaultWiki files with the files in the package. Some clients have options allowing you to only overwrite if timestamps are newer; avoid using this option.
Most opcode caches use a similar timestamp-comparison feature to determine if the cache is stale. If you KNOW the cache is stale, you should actively expire it.
You can confirm if it was a cache issue by following these steps:
1. Perform an innocuous, but easy to notice, template edit in a vaultwiki template.
2. Clear your opcode cache.
3. Visit the upgrade script and have it re-run the last upgrade.
4. Check if the template edit is still in effect, or if the control panel suggests a template is outdated.