Issue: Broken Links for an Article Doesn't Include Links Created via Template

Issue Tools
- View Changes

April 9, 2010 4:56 PM
Mokonzi

Senior Member
Broken Links for an Article Doesn't Include Links Created via Template

Broken Links for an Article Doesn't Include Links Created via Template

The Broken Links option (which relates to the Wanted Pages for a Specific Article) doesn't list wanted links created through templates.

This works at least in this instance.

A template has a command like:

Code:

[if="{{{avariable|}}}"][wiki]{{{avariable}}}[/wiki][else /]None[/if]

That would create links, but if they are missing, the Broken Links doesn't count them.

Issue Details

Issue Number 1405

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 3.0.0 RC 1

Fixed Version 3.0.0 RC 2

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 9, 2010 5:15 PM

pegasus

VaultWiki Team

Fixed for the next build. In vault/special_class_template.php, find:

Code:

		if (!empty($vault->parser['db_links']))
		{
			return $text;
		}

		$this->parser->recursion['template']++;

Replace with:

Code:

		$this->parser->recursion['template']++;

Find:

Code:

		if (!empty($vault->parser['db_links']))
		{
			return $text;
		}

		$text = $this->parser->extension->parse($this->parser, $text);

Replace with:

Code:

		$text = $this->parser->extension->parse($this->parser, $text);

In vault/special_class_bbcode_ext.php, find:

Code:

		$value = trim(strtolower($value));
		$parser->options['cachable'] = false;

Add before:

Code:

		global $vault;

		if (!empty($vault->parser['db_links']))
		{
			return '';
		}

In vault/special_class_bbcode.php, find:

Code:

				$GLOBALS['threadinfo']['namespaceid'] != TEMPLATE_SPACE AND
				$this->recursion['level'] == 1 AND
				empty($vault->parser['db_links']) AND
				!$this->end_parse

Replace with:

Code:

				$GLOBALS['threadinfo']['namespaceid'] != TEMPLATE_SPACE AND
				$this->recursion['level'] == 1 AND
				!$this->end_parse

April 9, 2010 5:28 PM

Mokonzi

Senior Member

Still not getting any joy on this.

Example:

http://www.thexuniverse.com/showwiki/Otas+Boreas

Notice the None that's listed as a wiki page, but doesn't show on the broken links.

Reply
April 9, 2010 5:57 PM

pegasus

VaultWiki Team

The page's cache was last generated on March 30. You needed to edit the page or the template again in order to rebuild the data.

Reply
April 10, 2010 2:34 AM

Mokonzi

Senior Member

I edited the template, but that didn't work. Editing the article did. When the fix is added in the next RC, will the update rerun the cache?

Reply
April 10, 2010 12:13 PM

pegasus

VaultWiki Team

No, the cache is usually too large to completely regenerate. You usually have to wait for the Cached Posts Lifespan to be reached, or you can clear the cache in VaultWiki > Wiki Maintenance Tools.

Reply
April 10, 2010 12:14 PM

Mokonzi

Senior Member

Cool. Will run that after my update to 4.0.3 in the morning.

Reply

+ Reply

All times are GMT -4. The time now is 9:42 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Broken Links for an Article Doesn't Include Links Created via Template

Issue Tools