Finder.php at line 1821

Issue Tools
- View Changes

December 27, 2024 6:07 PM

Alfa1

Distinguished Member

InvalidArgumentException: Unknown column vw_varname on XF:BbCode in src/XF/Mvc/Entity/Finder.php at line 1821

If I disable VW, then I get this one:

InvalidArgumentException: Unknown column vw_varname on XF:BbCode in src/XF/Mvc/Entity/Finder.php at line 1821

XF\Mvc\Entity\Finder->resolveFieldToTableAndColumn() in src/XF/Mvc/Entity/Finder.php at line 623
XF\Mvc\Entity\Finder->columnSqlName() in src/XF/Mvc/Entity/Finder.php at line 287
XF\Mvc\Entity\Finder->buildCondition() in src/XF/Mvc/Entity/Finder.php at line 422
XF\Mvc\Entity\Finder->buildConditionFromArray() in src/XF/Mvc/Entity/Finder.php at line 187
XF\Mvc\Entity\Finder->whereOr() in src/addons/vw/vw/Setup.php at line 1396
vw\vw\Setup->onActiveChange() in src/XF/AddOn/AddOn.php at line 704
XF\AddOn\AddOn->onActiveChange() in src/XF/AddOn/DataManager.php at line 206
XF\AddOn\DataManager->triggerRebuildActiveChange() in src/XF/Entity/AddOn.php at line 128
XF\Entity\AddOn->_postSave() in src/XF/Mvc/Entity/Entity.php at line 1324
XF\Mvc\Entity\Entity->save() in src/XF/Admin/Controller/AddOnController.php at line 134
XF\Admin\Controller\AddOnController->actionToggle() in src/XF/Mvc/Dispatcher.php at line 362
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 265
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
XF\App->run() in src/XF.php at line 806
XF::runApp() in admin.php at line 15

It could be related to this:
https://www.vaultwiki.org/issues/6461/#note35786
https://xenforo.com/community/thread...6#post-1724810

Issue Details

Issue Number 6463

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.8

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

December 27, 2024 7:09 PM
pegasus

VaultWiki Team
I believe this is possible if you disable the VaultWiki add-on while:

a VW upgrade from XenForo 1.x to XenForo 2.x has started but not finished yet, OR
a fresh VW installation has started but not finished yet

In this case, this code doesn't need to run, so we can make the following tweak.
In src/addons/vw/vw/Setup.php, find:

Code:

else { $data = [];

Replace with:

Code:

else if ($bbfinder->isColumnValid('vw_varname')) { $data = [];

The other possibilities for this to happen are if you are in developer mode and manually disable/remove the class extension for XF\Entity\BbCode, before attempting to disable the VaultWiki add-on, or if there is a third party add-on conflict that is not extending XF\Entity\BbCode correctly.
Reply
December 27, 2024 7:46 PM

Alfa1

Distinguished Member

Im not in developer mode. I did however, change the wiki bbcode CAT and removed the wiki bbcode CATEGORY:
https://www.vaultwiki.org/issues/6244/
Not sure if that is related.

I have added the fix and now its possible to disable the addon.

Reply
December 27, 2024 8:56 PM

Alfa1

Distinguished Member

Now it doesnt seem possible to enable the addon:

XF\Db\Exception: MySQL statement prepare error [1146]: Table 'xxx.vw_log' doesn't exist in src/XF/Db/AbstractStatement.php at line 230

XF\Db\AbstractStatement->getException() in src/XF/Db/Mysqli/Statement.php at line 207
XF\Db\Mysqli\Statement->getException() in src/XF/Db/Mysqli/Statement.php at line 46
XF\Db\Mysqli\Statement->prepare() in src/XF/Db/Mysqli/Statement.php at line 61
XF\Db\Mysqli\Statement->execute() in src/XF/Db/AbstractAdapter.php at line 96
XF\Db\AbstractAdapter->query() in src/addons/vw/vw/_core/controller/db/xf2.php at line 227
vw_DB_Controller_XF2->query_first() in src/addons/vw/vw/_core/model/db/mysql/vw.php at line 25
vw_DB_MySQL_Model->select() in src/addons/vw/vw/Setup.php at line 1349
vw\vw\Setup->onActiveChange() in src/XF/AddOn/AddOn.php at line 704
XF\AddOn\AddOn->onActiveChange() in src/XF/AddOn/DataManager.php at line 206
XF\AddOn\DataManager->triggerRebuildActiveChange() in src/XF/Entity/AddOn.php at line 128
XF\Entity\AddOn->_postSave() in src/XF/Mvc/Entity/Entity.php at line 1324
XF\Mvc\Entity\Entity->save() in src/XF/Admin/Controller/AddOnController.php at line 134
XF\Admin\Controller\AddOnController->actionToggle() in src/XF/Mvc/Dispatcher.php at line 362
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 265
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
XF\App->run() in src/XF.php at line 806
XF::runApp() in admin.php at line 15

Reply

December 28, 2024 10:11 AM

Alfa1

Distinguished Member

Originally Posted by pegasus

The other possibilities for this to happen are ... if there is a third party add-on conflict that is not extending XF\Entity\BbCode correctly.

Is this error related? It also concerns the finder.

Code:

ErrorException: [E_WARNING] Declaration of SV\WordCountSearch\XF\Pub\Controller\Forum::applyForumFilters(XF\Entity\Forum $forum, XF\Finder\Thread $threadFinder, array $filters) should be compatible with XF\Pub\Controller\ForumController::applyForumFilters(XF\Entity\Forum $forum, XF\Finder\ThreadFinder $threadFinder, array $filters) in src/addons/SV/WordCountSearch/XF/Pub/Controller/Forum.php at line 0

    XF::handlePhpError() in src/vendor/composer/ClassLoader.php at line 576
    include() in src/vendor/composer/ClassLoader.php at line 576
    Composer\Autoload\{closure}() in src/vendor/composer/ClassLoader.php at line 427
    Composer\Autoload\ClassLoader->loadClass()
    spl_autoload_call() in src/XF.php at line 414
    XF::createAliasForClass()
    spl_autoload_call()
    class_exists() in src/XF/Extension.php at line 215
    XF\Extension->extendClass() in src/XF/App.php at line 3385
    XF\App->extendClass() in src/XF/App.php at line 1854
    XF\App->XF\{closure}() in src/XF/Container.php at line 233
    XF\Container->create() in src/XF/App.php at line 3337
    XF\App->controller() in src/XF/Mvc/Dispatcher.php at line 301
    XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 265
    XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
    XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
    XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
    XF\App->run() in src/XF.php at line 806
    XF::runApp() in index.php at line 23

Also see the comments by Xon in this thread:
https://xenforo.com/community/thread...6#post-1724810

Originally Posted by Xon

XF\Finder\Thread should be automatically aliased to XF\Finder\ThreadFinder in XF2.3, and there was a bunch of bugfix work in the early XF2.3 betas around that. The only thing I can think of it there is a broken cache which wasn't rebuilt in the XF1 => XF2.3 update process which should have been rebuilt.

I did rebuild master data but to no avail.

December 28, 2024 12:32 PM
pegasus

VaultWiki Team
That error is not related, but from my experience developing for XF 2.3, I can say that I believe the "Declaration ... should be compatible" message is correct. Basically the PHP parser wants the type hints to match exactly. It doesn't care that one class is_a the other class, as far as the signature is concerned. It only considers that to be okay when the actual arguments get passed.

The way we dealt with issues like this in VaultWiki was to create multiple versions of many classes, that use traits that are only slightly different, depending on which minor version of XenForo 2.3 you were running. This is one reason why XenForo 2.3 support took a while from its initial release.

Basic example:

Code:

namespace Addon\Finder; class ThreadFinderBase extends XFCP_Thread { // code used by all variants } if (\XF::$versionid >= 2030053) // many classes suffixed in 2.3.0 RC 3 { class ThreadFinder extends ThreadFinderBase { // trait with XF\Finder\ThreadFinder in signature use Thread\XF23rc3; } } else { class ThreadFinder extends ThreadFinderBase { // trait with XF\Finder\Thread in signature use Thread\XF23a; } }

Where each trait has the varying signatures based on that XenForo version. If you try to support old versions of XenForo too, you end up with quite a few of these.
Reply

+ Reply

All times are GMT -4. The time now is 3:08 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: InvalidArgumentException: Unknown column vw_varname on XF:BbCode in src/XF/Mvc/Entity/Finder.php at line 1821

Issue Tools