Issue: Forum node: Wiki integration shows old username

Issue Tools
- View Changes

February 6, 2024 5:25 AM

mazzly

Junior Member

Forum node: Wiki integration shows old username

Reproduce:

1. Set up a wiki integration to show on the "homepage" of the Forum (Xenforo /admin.php?nodes/add)
2. Create a Wiki page in the same area as selected in step 1
3. Check that the New page shows up on the forum "homepage"
4. Change the username of the user that created/edited the page
5. Notice that the username and URL to user page have old values on the home page..
- Hovering will ofc show the correct username once the page loads in the modal...

Expectation:

Changing a username, should also be reflected on the forum nodes (e.g. XF Core nodes show the correct value for username)

Issue Details

Issue Number 6411

Issue Type Bug

Project VaultWiki 4.x Series

Category Areas

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

February 6, 2024 11:05 AM
pegasus

VaultWiki Team
The data in the node's last-update field work on a caching mechanism. I see that the contents of the cache are not cleared/updated when the username of the user who performed the last-update is changed. Please confirm if this is the username you are referring to.

You can also see if the username change is properly proliferated to uncached updates. To clear the entire cache:

Code:

DELETE FROM vw_lastupdatecache

I believe there is a way to propagate the change into the cache but it would require a new deferred task that gets triggered on username changes, since the cached username is not directly a column on the table.
Reply
February 7, 2024 1:26 AM

mazzly

Junior Member

By clearing the cache some of them changed, but only the ones I had edited since the username change...

Reply
February 7, 2024 9:37 AM
pegasus

VaultWiki Team
From what I can see, with a fresh cache there is a possibility the username shown could be incorrect but the profile link will have the correct username in it. Is this what you are seeing?

If so, in src/addons/vw/vw/_core/view/factory/last/vw.php, find:

Code:

$lastupdate['musername'] = vw_Hard_Core::model('User')->musername($lastupdate);

BEFORE it, add:

Code:

$lastupdate['username'] = vw_Hard_Core::model('String')->normalize($lastupdate['lastusername']); if (!vw_Hard_Core::model('User')->username_safe()) { $lastupdate['username'] = vw_Hard_Core::model('String')->htmlspecialchars_uni($lastupdate['username']); }

This occurs after the cache read so I don't think you need to clear it again.
Reply
February 24, 2024 9:53 AM

pegasus

VaultWiki Team

This should be fixed in the next release. When a user is renamed, or two users are merged, the user-update process should find matching entries in vw_lastupdate where lastuserid is one of the affected users and automatically clear any vw_lastupdatecache rows based on those entries.

Reply

+ Reply

All times are GMT -4. The time now is 2:43 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Forum node: Wiki integration shows old username

Issue Tools