Issue: Reflist stopped working

Issue Tools
- View Changes

January 12, 2024 8:15 AM

expanserpb

Junior Member

Reflist stopped working

Version 4.1.7

Example page:

https://chroniclesrp.net/Folklore/Hath-Charosh

Reflist tags are no longer displaying the list of references. I can't put my finger on when this stopped.

Issue Details

Issue Number 6405

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 12, 2024 10:37 AM
pegasus

VaultWiki Team
The change occurred in 4.1.6 but it is undocumented. The change was intended to reset the reflist when rendering different content, because it was possible for pages to hijack each other's reflists when multiple pages rendered, such as via integrations, feeds, or the INJECT BB-Code. However, it appears to be resetting the reflist every time a BB-Code gets used instead.

In src/addons/vw/vw/_core/model/parser/handle/wrapper/vw.php, find:

Code:

$obj = vw_Hard_Core::model($typed["$type"]["$subclass"]); $obj->_construct_delayed($this->parent);

Replace with:

Code:

$obj = vw_Hard_Core::model($typed["$type"]["$subclass"]); if (!$obj->parent OR $obj->parent->vwClassId != $this->parent->vwClassId) { $obj->_construct_delayed($this->parent); }

Additionally a recent bug fix to reflist highlighting may have prevented footnotes from working when no reflist was used (the tooltip variant).
In src/addons/vw/vw/_core/instance/parser/renderer/xf2.php, find:

Code:

if (strpos($text, '<a class="vw-footnote" ') !== false AND strpos($text, '<li class="vw-footnote-item" ') === false)

Replace with:

Code:

if (strpos($text, '<a class="vw-footnote ') !== false AND strpos($text, '<li class="vw-footnote-item ') === false)
Reply
January 27, 2024 6:12 AM

mazzly

Junior Member

@pegasus is there some way to be notified about when you "release" fixes for breaking things like this?

It is really bad that things break, but also that we have to find them ourselves or wait for the next release "which is always months away..." makes our Wiki quality be lacking...

Is there some list or subforum or similar you post when you have fixed various bugs so that I could subscribe to that and patch the things that are relevant for our Wiki?

Reply
January 27, 2024 6:15 AM

mazzly

Junior Member

Also, the file `src/addons/vw/vw/_core/parser/handle/wrapper/vw.php` doesn't seem to exist? Probably supposed to be `src/addons/vw/vw/_core/model/parser/handle/wrapper/vw.php`

Reply
January 27, 2024 6:17 AM

mazzly

Junior Member

And to verify: Yes the fixes you supplied have repaired the REFLIST to working again

Reply
January 27, 2024 10:42 AM

pegasus

VaultWiki Team

This is the link to subscribe to the VaultWiki 4.x project overall, which would keep you informed about bugs that get reported: https://www.vaultwiki.org/projectpos...n&projectid=10

Reply

+ Reply

All times are GMT -4. The time now is 2:41 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Reflist stopped working

Issue Tools