Issue: Wrong counts for Special:MostLinkedPages (doesn't respect setting for "Allow duplicate links")

Issue Tools
- View Changes

October 25, 2023 4:14 AM

mazzly

Junior Member

Wrong counts for Special:MostLinkedPages (doesn't respect setting for "Allow duplicate links")

We have "Allow duplicate links" disabled.

Pages listed on Special:MostLinkedPages show a higher link than what Special:WhatLinksHere does.

This is likely due to counting multiple mentions from the same pages multiple times (even though they won't be linked multiple times)

Issue Details

Issue Number 6399

Issue Type Bug

Project VaultWiki 4.x Series

Category Special Pages

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 25, 2023 10:23 PM

pegasus

VaultWiki Team

Fixed in the next release. In src/addons/vw/vw/_core/model/parser/handle/base/link/vw.php, find:

Code:

		if ($output['return'] !== false)
		{
			if (!empty($output['title']))
			{
				$this->add_link_row($output);
			}

BEFORE it, add:

Code:

		$autolink_options = vw_Hard_Core::model('Settings')->get('vw_autolink_flags');

		if (
			vw_Hard_Core::model('Settings')->get('vw_autolinks') AND
			!empty($output['itemid']) AND
			!($autolink_options & vw_Hard_Core::model('Bitfield')->get_bit('misc', 'vw_autolink_flags', 'double')) AND
			!empty($this->parent->autolinker)
		)
		{
			$this->parent->autolinker->ignore($output['itemtypeid'], $output['itemid']);
		}

October 26, 2023 1:05 AM
mazzly

Junior Member
There are 2 instances of

Code:

if ($output['return'] !== false)

in that file... which one should I add before?
Reply
October 26, 2023 1:10 AM

pegasus

VaultWiki Team

I've updated the find.

Reply

+ Reply

All times are GMT -4. The time now is 2:42 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Wrong counts for Special:MostLinkedPages (doesn't respect setting for "Allow duplicate links")

Issue Tools