Issue: Accessibility Fix ARIA attributes according to pagespeed feedback

Issue Tools
- View Changes

October 13, 2023 1:18 AM

mazzly

Junior Member

Accessibility Fix ARIA attributes according to pagespeed feedback

[aria-*] attributes do not have valid values

on:
https://pagespeed.web.dev/analysis/h...r=mobile&hl=en

We also have another one here:
https://pagespeed.web.dev/analysis/h...=desktop&hl=en
(The Aria-ID one is not from vw, we need to fix that from the theme)

Issue Details

Issue Number 6386

Issue Type Bug

Project VaultWiki 4.x Series

Category Search Engine Optimization

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 13, 2023 10:18 AM

pegasus

VaultWiki Team

My understanding is that aria-expanded and aria-haspopup are custom properties used by the menu system in one of the forum softwares that VaultWiki works with (which one I will need to check). Since it appears in both forum softwares as you've shown, it is possible that this is a bug.

However, I believe that one of these is correct insofar as it is compatible with the underlying menu system. Unfortunately the menu system is not compliant, but there is not much we can do about that, as it's not VaultWiki's software. We will fix the properties on whichever software they are unused.

Reply
October 13, 2023 10:22 AM

mazzly

Junior Member

Yeah I think one of them actually comes from the theme we're using on XF.. Will need to manually fix that.. The other one seems to be coming from VW software

Reply
October 23, 2023 12:45 PM

pegasus

VaultWiki Team

Fixed the one instance of aria-haspopup referenced by the link, which did not have a role associated with it, by adding the role. I was unable to find other usages that did not have roles in XenForo. In vBulletin, aria tags are generated by the mobile style's Javascript, not VaultWiki. If there are additional aria problems under XenForo, please report them separately.

Reply
October 23, 2023 1:07 PM

mazzly

Junior Member

How do I get the fix applied to our Xenforo site?

Reply
October 23, 2023 3:22 PM
pegasus

VaultWiki Team
You'll end up with a modified vw_node_tabs template, but find:

Code:

data-xf-click="menu"

AFTER it, add:

Code:

role="button"
Reply

+ Reply

All times are GMT -4. The time now is 2:51 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Accessibility Fix ARIA attributes according to pagespeed feedback

Issue Tools