Issue: Vault Wiki breaks quoting quotation marks

Issue Tools
- View Changes

March 30, 2023 4:38 PM

Vilandra

New Member

Vault Wiki breaks quoting quotation marks

When quoting a post that has quotation marks in XF 2.2.12 with Vault Wiki 4.1.6 enabled, the quotation marks are omitted from the quote.

This is a weird one. When I have VW 4.1.6 enabled, and I try to quote a post that has quotation marks in it in XF 2.2.12, the quotation marks are then omitted from the quote in the reply box. Disabling VW returns correct functionality.

Issue Details

Issue Number 6371

Issue Type Bug

Project VaultWiki 4.x Series

Category Forum Posts / Non-Wiki Content

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.6

Fixed Version 4.1.7

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags xenforo

April 1, 2023 2:34 AM
pegasus

VaultWiki Team
Fixed in the next release. Quotation marks are not supposed to be transferred if the source or target content is wiki content, because there is a little-known attack vector under certain wiki setting combinations, but there is no current reason why they cannot be copied from regular posts into other regular posts.

In src/addons/vw/vw/XF/ControllerPlugin/Quote.php, find:

Code:

$arrayContent['containerid'] = $arrayContent['areaid'];

AFTER it, add:

Code:

$wasWiki = true;

Find:

Code:

if (!empty($arrayContent['containerid']))

Replace with:

Code:

if (!empty($wasWiki))

However, whenever forum posts regain the VW3 ability to be wikified, then this change would be an attack vector, and another method of protecting the target content should be used, such as wrapping XF/Pub/Controller/Post::actionQuote when a custom URL parameter is present.
Reply
April 1, 2023 10:58 AM

Vilandra

New Member

Fixed - thank you very much!

Reply

+ Reply

All times are GMT -4. The time now is 1:03 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Vault Wiki breaks quoting quotation marks

Issue Tools