Issue: [4.1.2] Adding pages to category: Trying to access array offset on value of type null

Issue Tools
- View Changes

August 25, 2021 8:16 AM

ACL

Regular Member

[4.1.2] Adding pages to category: Trying to access array offset on value of type null

[E_NOTICE] Trying to access array offset on value of type null src/addons/vw/vw/_core/controller/ui/assign/category/vw.php:1211

This error is logged when adding an existing page to a category (view Page's "Categories:" edit categories pencil icon).

Code:

#0 src/addons/vw/vw/_core/controller/ui/assign/category/vw.php(1211): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/au...', 1211, Array)
#1 src/addons/vw/vw/_core/view/ui/assign/vw.php(454): vw_UI_Assign_Category_Controller->from(Array, Array, Object(vw_UI_Assign_Append_Category_View))
#2 src/addons/vw/vw/_core/view/ui/assign/append/vw.php(95): vw_UI_Assign_View->get_results(Array)
#3 src/addons/vw/vw/_core/view/ui/assign/vw.php(176): vw_UI_Assign_Append_View->get_results(Array)
#4 src/addons/vw/vw/_core/view/reply/view/vw.php(48): vw_UI_Assign_View->ajax_results(Array)
#5 src/addons/vw/vw/_core/view/reply/base/vw.php(134): vw_Reply_View_View->render_type('xml')
#6 src/addons/vw/vw/XF/Mvc/View.php(74): vw_Reply_base_View->render('xml')
#7 src/XF/Mvc/Renderer/AbstractRenderer.php(91): vw\vw\XF\Mvc\View->renderXml()
#8 src/XF/Mvc/Renderer/Xml.php(74): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('vw\\vw:Wiki', 'public:vw_gener...', Array)
#9 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Xml->renderView('vw\\vw:Wiki', 'public:vw_gener...', Array)
#10 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Xml), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Xml), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'xml')
#13 src/XF/App.php(2344): XF\Mvc\Dispatcher->run()
#14 src/XF.php(512): XF\App->run()
#15 index.php(20): XF::runApp('XF\\Pub\\App')
#16 {main}

Issue Details

Issue Number 6249

Issue Type Bug

Project VaultWiki 4.x Series

Category Categories

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.1.2

Fixed Version (none)

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 25, 2021 12:07 PM

pegasus

VaultWiki Team

I cannot reproduce this issue. Can you please provide more information about the request state that triggers this error? Ideally a sniff of the POST variables that are sent in the request (Chrome Dev > Network > (triggering request) > Headers > Query String Parameters & Form Data (excluding _xfToken)).

Reply

August 25, 2021 1:59 PM

ACL

Regular Member

I must have made a mistake in documenting the reproducing steps, as I too cannot trigger the reported error when following my own post, d'oh

. I'll have to keep a more regular eye on the error log the next time I make changes to the wiki to hopefully figure out what I actually did. Sorry.

Taking a closer look at the error log, 100 of the newest entries related to this report share the same referrer and timestamp (7:57 pm). This referrer is a new category with a revision timestamp of 1 minute prior (7:56 pm). The remaining 412 (of total 512) share a second referrer and timestamp (12:17 am). This second referrer is an older category that was created a long time ago in 2017. These two categories aren't the only ones involved with my wiki maintenance. A few other new categories were created and a handful of pages added to them, yet those haven't appeared in the error log.

The two unique request states:

Code:

array(4) {
  ["url"] => string(34) "/index.php?wiki-ajax/&c=assignable"
  ["referrer"] => string(56) "(suppressed: preexisting category page)"
  ["_GET"] => array(2) {
    ["wiki-ajax/"] => string(0) ""
    ["c"] => string(10) "assignable"
  }
  ["_POST"] => array(11) {
    ["ajax"] => string(1) "1"
    ["query"] => string(0) ""
    ["filter"] => string(6) "append"
    ["from"] => string(8) "category"
    ["assignto"] => string(8) "category"
    ["fromid"] => string(1) "0"
    ["exclude"] => array(1) {
      [0] => string(3) "NaN"
    }
    ["contextrule"] => string(9) "not-below"
    ["contextid"] => string(3) "797"
    ["_xfToken"] => string(8) "********"
    ["c"] => string(10) "assignable"
  }
}

Code:

array(4) {
  ["url"] => string(34) "/index.php?wiki-ajax/&c=assignable"
  ["referrer"] => string(64) "(suppressed: recently created category page)"
  ["_GET"] => array(2) {
    ["wiki-ajax/"] => string(0) ""
    ["c"] => string(10) "assignable"
  }
  ["_POST"] => array(11) {
    ["ajax"] => string(1) "1"
    ["query"] => string(0) ""
    ["filter"] => string(6) "append"
    ["from"] => string(8) "category"
    ["assignto"] => string(8) "category"
    ["fromid"] => string(1) "0"
    ["exclude"] => array(1) {
      [0] => string(3) "NaN"
    }
    ["contextrule"] => string(9) "not-below"
    ["contextid"] => string(4) "1072"
    ["_xfToken"] => string(8) "********"
    ["c"] => string(10) "assignable"
  }
}
}

August 25, 2021 7:58 PM

pegasus

VaultWiki Team

Thanks, I think the problem is the filter=append. This is probably intentional, but it looks like the piece that would lead to the notice (append isn't a real filter name).

If you can figure out the steps to reproduce, that would still be helpful (so I can confirm any fix). Judging by your referrer description, I'm guessing:
1. On category page view, click Add Listing > Add existing page.
2. Filter pages by category.
3. E_NOTICE

Reply

August 26, 2021 5:41 AM

ACL

Regular Member

Thanks pegasus, your presumption was correct it is the 'Organize results by: Category' that does it. With that reminder, yes I did choose this option at the two unique times the errors were logged.

Originally Posted by pegasus

1. On category page view, click Add Listing > Add existing page.
2. Filter pages by category.
3. E_NOTICE

Choosing to 'Organize results by: Prefix' also triggers the same kind of error with a slightly different stack trace and request state:

Code:

#0 src/addons/vw/vw/_core/controller/ui/assign/prefix/vw.php(82): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/au...', 82, Array)
#1 src/addons/vw/vw/_core/view/ui/assign/vw.php(454): vw_UI_Assign_Prefix_Controller->from(Array, Array, Object(vw_UI_Assign_Append_Category_View))
#2 src/addons/vw/vw/_core/view/ui/assign/append/vw.php(95): vw_UI_Assign_View->get_results(Array)
#3 src/addons/vw/vw/_core/view/ui/assign/vw.php(176): vw_UI_Assign_Append_View->get_results(Array)
#4 src/addons/vw/vw/_core/view/reply/view/vw.php(48): vw_UI_Assign_View->ajax_results(Array)
#5 src/addons/vw/vw/_core/view/reply/base/vw.php(134): vw_Reply_View_View->render_type('xml')
#6 src/addons/vw/vw/XF/Mvc/View.php(74): vw_Reply_base_View->render('xml')
#7 src/XF/Mvc/Renderer/AbstractRenderer.php(91): vw\vw\XF\Mvc\View->renderXml()
#8 src/XF/Mvc/Renderer/Xml.php(74): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('vw\\vw:Wiki', 'public:vw_gener...', Array)
#9 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Xml->renderView('vw\\vw:Wiki', 'public:vw_gener...', Array)
#10 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Xml), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Xml), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'xml')
#13 src/XF/App.php(2344): XF\Mvc\Dispatcher->run()
#14 src/XF.php(512): XF\App->run()
#15 index.php(20): XF::runApp('XF\\Pub\\App')
#16 {main}

Request state:

Code:

array(4) {
  ["url"] => string(39) "/XF22/index.php?wiki-ajax/&c=assignable"
  ["referrer"] => string(57) "(suppressed)"
  ["_GET"] => array(2) {
    ["wiki-ajax/"] => string(0) ""
    ["c"] => string(10) "assignable"
  }
  ["_POST"] => array(11) {
    ["ajax"] => string(1) "1"
    ["query"] => string(0) ""
    ["filter"] => string(6) "append"
    ["from"] => string(6) "prefix"
    ["assignto"] => string(8) "category"
    ["fromid"] => string(1) "0"
    ["exclude"] => array(1) {
      [0] => string(3) "NaN"
    }
    ["contextrule"] => string(9) "not-below"
    ["contextid"] => string(4) "1079"
    ["_xfToken"] => string(8) "********"
    ["c"] => string(10) "assignable"
  }
}

August 26, 2021 5:46 AM

ACL

Regular Member

Query string parameters (Organize by category & Organize by prefix):

Code:

wiki-ajax/: 
c: assignable

Form data (Organize by category):

Code:

ajax: 1
query: 
filter: append
from: category
assignto: category
fromid: 0
exclude[]: NaN
contextrule: not-below
contextid: 1079
_xfToken: (suppressed)
c: assignable

Form data (Organize by prefix):

Code:

ajax: 1
query: 
filter: append
from: prefix
assignto: category
fromid: 0
exclude[]: NaN
contextrule: not-below
contextid: 1079
_xfToken: (suppressed)
c: assignable

August 26, 2021 11:01 AM

pegasus

VaultWiki Team

Fixed in the next release. The problem occurred in all "Organize results by" choices, if using the "Add existing" link from within the target container (append mode).

Reply

+ Reply

All times are GMT -4. The time now is 3:35 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1.2] Adding pages to category: Trying to access array offset on value of type null

Issue Tools