Issue: Since latest upgrade, wiki interfering with the text editor of add-on

Issue Tools
- View Changes

May 15, 2020 6:15 PM

beernuts

Junior Member

Since latest upgrade, wiki interfering with the text editor of add-on

We use a member notes add-on, it's always worked fine with VaultWiki. Ever since this latest VW upgrade though, the editor for the member notes never loads. JS console shows this error:

Code:

Uncaught ReferenceError: vw_Hard_Core is not defined
    at HTMLDocument.<anonymous> (final.js?_v=9d39e39a:11)
    at HTMLDocument.dispatch (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at HTMLDocument.v.handle (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at Object.trigger (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at HTMLDocument.<anonymous> (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at Function.each (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at k.fn.init.each (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at k.fn.init.trigger (jquery-3.4.1.min.js?_v=9d39e39a:2)
    at HTMLDocument.startAll (editor-compiled.js?_v=9d39e39a:50)
    at HTMLDocument.i (jquery-3.4.1.min.js?_v=9d39e39a:2)

Issue Details

Issue Number 6036

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 RC 3

Fixed Version 4.2.0 Alpha 1

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

May 15, 2020 8:01 PM
pegasus

VaultWiki Team
Fixed the editor not loading here in the next build. This occurs if the File Browser button is available in editors generally, but if there are no editors present on the current page, and an editor gets added via an AJAX response. In this case, it is possible for the Javascripts to load out of order. If the XenForo JS loads before the VW JS, the VW editor functions are not available yet and errors will be thrown. Due to the page being loaded already, events like documentReady are not possible to resolve the situation (documentReady already fired, so XenForo's editor script is "activating" immediately, before the AJAX response has finished parsing other scripts).

In order to get the editor to load successfully, in js/vw/vw/xf2/froala/final.js, find:

Code:

vw_Hard_Core.setup('platform-editor', 'vw_Editor_Platform', '');

BEFORE it, add:

Code:

if (typeof(vw_Hard_Core) == 'undefined') return;

In this situation, you will probably still have difficulty using some editor buttons like the File Browser, even if the editor loads successfully. Generally it is recommended that the container page already has the various basic Javascript libraries loaded (xenforo.js, jquery, YUI3, vw_Hard_Core, etc) as part of the main document to prevent problems like this. We will probably force vw_Hard_Core on all pages in VW 4.2 to resolve this, after we remove the bulky YUI3 dependency. In the mean time, you will probably need to accept that wiki-button functionality will be spotty in Member Notes and other non-core editors.
Reply
October 4, 2020 3:19 AM

pegasus

VaultWiki Team

Closing this as resolved in 4.2.x. js/vw/vw/base.js is now loaded on all pages, as it only requires jQuery.

Reply

+ Reply

All times are GMT -4. The time now is 11:29 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Since latest upgrade, wiki interfering with the text editor of add-on

Issue Tools