Issue: Files don't upload to the wiki

For debugging attachment problems, please add the following line to your wiki config file, located at src/addons/vw/vw/config.php:
You will not want to leave this on all the time, since attachment errors might prevent already-uploaded files from rendering. However, the errors can be useful in determining why something is failing to upload.

I've adjusted the config file as requested and re-attempted upload.

I noticed after correcting the rules attachment issue in the other bug report that the broken image icon no longer appeared. Instead, uploading files produces the progress gif. See image.



However I'm also running into a new possibly related issue where after selecting a file to upload clicking anywhere on the page will re-open the directory selector as if I'm choosing a file to upload. The only fix for this is to smash the Tab key a few times to get it off whatever it's stuck on.

As for the results of the upload attempt: it fails after a few minutes. See image.



No server logs were produced in the ACP. Is there somewhere I should be looking for VW specific logs?

Thanks.

If you are comfortable opening your browser's Developer Tools/Console, it will be helpful to look at the Network activity, specifically an XHR request going to wiki-ajax/?c=upload, and reviewing the response data from that request.

The browser's Javascript console may also reveal if there are Javascript errors.

I'm currently unable to reproduce the behavior described, so any new information will be helpful.

EDIT: I was able to reproduce the file dialog reopening on outer click when using Firefox.

The reopening dialog seems to be related to Firefox reapplying focus to the last-focused input after closing a dialog, even if that input was not actually focused at the time the dialog was opened.

I stopped encountering this behavior by making the following change to js/vw/vw/upload.js. Find:
Replace with:

Yes, the issue occurred with Firefox. I should've mentioned that, my bad.
I am currently debugging the issue as you described above and will report back once I've found something.

I have replied in a private comment with the results of the debugging.

The default value for X-Frame-Options in XenForo 2 is "SAMEORIGIN". Are you aware of a reason why it is set to "DENY"? That is the culprit.

No, I'm not sure why it would be set that way. I'm looking into how & where to change it.

Alright, I've figured it out. It was set that way in my nginx configuration, most likely a recommended setting I picked up online somewhere and applied without much thought and it happened to work without issue until now.

I've tested and everything is working properly now.

Well, I hope my blunder here at least helps someone else later down the road.
Thank you for your time again.

Marking this as fixed in the next release.

To add support for X-Frame-Options: DENY, we abandon the old iframe upload technique in favor of HTML5 uploading. Since XF2 uses HTML5 consistently, and since we no longer support old versions of Internet Explorer, this should be a safe change.