Issue: [4.1 RC 2] Problem with HTML on page editor when page's content type has been disabled, unable to uncheck it

Issue Tools
- View Changes

April 8, 2020 10:48 AM
ACL

Regular Member
[4.1 RC 2] Problem with HTML on page editor when page's content type has been disabled, unable to uncheck it

When editing a wiki page where the current content type has been disabled, the rendered HTML in the "Treat this page as a" form row is garbled. The 'loss of functionality' part of the report is that the garbled HTML means it isn't possible to uncheck the disabled content type.

Pasted below is how the HTML looks (formatted slightly to help with readability) when attempting to edit a book where the book content type was later disabled:

Code:

<dd> <div class="vw-switch-types "> <input type="hidden" name="typelist[18]" value="0"> <ul class="inputChoices"> <li class="inputChoices-choice"> <label class="iconic"> <input type="checkbox" name="typelist[18]" value="1" checked="checked" data-vw-trigger="typelist-option" class="vw-typelist-option vw-typelist-container vw-typelist-disabled" afterhtml="<div class=" vw-error-list="" errorpanel"="" id="yui_3_5_0_1_1586354670447_11">IMPORTANT! This type is no longer permitted. You will not be able to save any changes to this page until this type is removed. </label> </li> </ul></div>" /><i aria-hidden="true"></i><span class="iconic-label">Book, so it can contain sub-pages</span> </dd>

Perhaps this 'type is no longer permitted' warning could also be styled better in XenForo 2.x, such as a div element with the CSS classes: .block-rowMessage .block-rowMessage--small .block-rowMessage--warning

Issue Details

Issue Number 6014

Issue Type Bug

Project VaultWiki 4.x Series

Category Editing Pages

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 RC 2

Fixed Version 4.1.0 RC 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 8, 2020 11:07 AM
pegasus

VaultWiki Team
Fixed in the next release, and updated the phrase with the CSS classes you mentioned. To fix the broken HTML, in the template vw_editor_types, find:

Code:

afterHtml

Replace with:

Code:

afterhtml
Reply

+ Reply

All times are GMT -4. The time now is 2:34 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 RC 2] Problem with HTML on page editor when page's content type has been disabled, unable to uncheck it

Issue Tools