Templater.php:914

Issue Tools
- View Changes

September 29, 2019 8:56 AM

beernuts

Junior Member

Template error: Function vw_integrate is unknown src/XF/Template/Templater.php:914

Code:

#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Function vw_int...', '/home/badgerand...', 914, Array)
#1 src/XF/Template/Templater.php(914): trigger_error('Function vw_int...', 512)
#2 internal_data/code_cache/templates/l1/s5/public/thread_view.php(761): XF\Template\Templater->func('vw_integrate', Array, true)
#3 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(SV\ConversationEssentials\XF\Template\Templater), Array)
#4 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#5 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#6 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#7 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#8 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#10 src/XF/App.php(2178): XF\Mvc\Dispatcher->run()
#11 src/XF.php(390): XF\App->run()
#12 index.php(20): XF::runApp('XF\\Pub\\App')
#13 {main}

Issue Details

Issue Number 5881

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Forum Bug

Priority 4 - Warnings / Script Errors

Affected Version 4.1.0 Beta 3

Fixed Version (none)

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 29, 2019 9:49 AM
pegasus

VaultWiki Team
If you only see this one time in your logs, then this doesn't seem like a bug in VaultWiki.

There are a number of ways I would expect this to happen:
- Manually disabling VaultWiki's listener on templater_setup
- Another add-on has a listener on templater_setup that returns false
- The following race condition in XenForo 2:

In XenForo 2, when an add-on is currently disabled and then enabled:

XenForo changes the add-on's active state and saves it.
XenForo queues to rebuild listeners closer to the end of the current request.
XenForo saves a new job where template modifications related to the add-on will be compiled into templates.
Some time passes, while the request performs some other tasks.
In this same request, the queued listener rebuild finally executes.

Between #3 and #5, it is possible for another user to access the forum. At this moment, the user will run the template-modification job. In theory, the job can complete before #5 above. If a third user accesses the forum in this period, the user can view the add-on's template modifications even though the add-on's listeners are not public yet.

In this case, the third user will see this error message if the add-on's template modifications use template functions that are added by the same add-on (which seems reasonable to me). Once #5 runs, the error will no longer occur.

There is really nothing VaultWiki can do about this rare situation. I'm not sure there is much XF devs can do about it either, although you may wish to raise the situation with them, since it is related to the way add-on activations are designed. In general I think we just have to accept that while rebuilds are part-way completed, weird things can happen.
Reply
September 29, 2019 9:51 AM

beernuts

Junior Member

Alright. We did disable the wiki when this appeared, I believe, though I had about 6 pages of this error. I'll chalk it up to being caused by the rebuild process.

Reply
September 29, 2019 10:03 AM

pegasus

VaultWiki Team

Oh, if I think about it, there is a lot more time for it to occur in the opposite direction (while disabling the add-on) -- possibly several seconds, depending how many add-ons you have. In the normal flow, this is because the add-on listeners would be disabled before the subsequent request which recompiles template modifications.

Reply
April 8, 2020 9:06 AM

pegasus

VaultWiki Team

While this error message is due to a design flaw in XenForo 2, there is a method to suppress the error. We have implemented that method for our add-on's template modifications in the next release.

The suppression method is to check if the add-on is enabled, while inside the template modification. But since template modifications are automatically disabled when the add-on is disabled, checking if the same add-on is enabled inside its template modifications should have been redundant (hence XenForo still has a design flaw).

Reply
April 8, 2020 9:28 AM

gerryvz

New Member

You are correct in that both occurrences of this error that I have experienced, have been in conjunction with VaultWiki being disabled, when updating the VW software.

Reply

+ Reply

All times are GMT -4. The time now is 2:34 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Template error: Function vw_integrate is unknown src/XF/Template/Templater.php:914

Issue Tools