Issue: [4.1 Beta 3] Renaming or merging user accounts leads to various issues with wiki revision contributors

Issue Tools
- View Changes

September 28, 2019 5:17 AM
ACL

Regular Member
[4.1 Beta 3] Renaming or merging user accounts leads to various issues with wiki revision contributors

Below is a handful of behaviours I've witnessed as a result of renaming and merging user accounts in the XF2 admin cp for testing purposes.

When a username is renamed:

Approval queue: Username is not updated in the XF2 approval queue for wiki contributions, UNLESS that user also has core content awaiting approval (e.g. thread post). When their core content is approved, the approval queue wiki items change back to their old username.
Vwpage .vw-list-contributors: 'Last updated by' username is not updated to new username.
Area .vw-content-list-update: Username is not updated.

When a user is merged with another user, wiki contributions are not reassociated with the destination account:

Approval queue: Username and avatar are hidden, user id changed to 0.
Vwpage .vw-list-contributors: Username and user id refer to the deleted (merged) account, 404 error when attempting to show member tooltip.
Area .vw-content-list-update: Username and user id refer to the deleted (merged) account, 404 error when attempting to show member tooltip.
Area .vw-content-list-contribs: User shows as "Guest" in content lists.
Special:Contributions?userid=x no results for merged user (Merged/deleted user contributions are not shown). Edit: Destination user hasn't edited the wiki, but merged (deleted) user has.
XF2 latest activity: news feed item is missing any username, e.g.:

edited the Page test 2 times

The user_content_change_init and user_merge_combine XF2 code event listeners may be useful here?

Issue Details

Issue Number 5879

Issue Type Bug

Project VaultWiki 4.x Series

Category History / Revisions

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 4.1.0 Beta 3

Fixed Version 4.1.0 Beta 4

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 28, 2019 12:31 PM

pegasus

VaultWiki Team

Fixed in the next release. This was caused by VaultWiki's user-merge and user-rename related functions not being implemented under XenForo 2.

Users merged after upgrading should have their wiki-related data upgraded correctly. Users merged before upgrading cannot be fixed since the source data is already gone.

Reply
November 4, 2019 8:55 AM

ACL

Regular Member

Thanks, I have briefly tested user merges under VW4.1 Beta 4 b004. For the most part things look good.

Although, I did discover that merged user username and user id are not updated for a page's most recent update event on the Area page list (vw-content-list-update). It has updated in vw-content-list-contribs.

On the page itself, the "Last updated by: x" list (vw-list-contributors) correctly displays the merged username and userid. Page version history username/userid is also correct.

Reply
November 5, 2019 8:00 AM

pegasus

VaultWiki Team

We will need to make some changes for content-list last-update fields in the database, since this information is not stored in a way that could be easily updated without unpacking every row individually first.

Reply
January 1, 2020 5:24 PM

pegasus

VaultWiki Team

Fixed last-update in the next release. New columns vw_lastupdate.lastuserid and vw_lastupdate.lastusername store the user information for the user that performed the update in a way that is easily handled by user renames and merges.

Reply

+ Reply

All times are GMT -4. The time now is 3:47 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 3] Renaming or merging user accounts leads to various issues with wiki revision contributors

Issue Tools