Issue: [4.1 Beta 2] Editing pages: New Attachment/Category buttons slightly off-center vertically (trivial CSS issue), File Browser overlay missing caption label

Issue Tools
- View Changes

July 23, 2019 4:21 PM
ACL

Regular Member
[4.1 Beta 2] Editing pages: New Attachment/Category buttons slightly off-center vertically (trivial CSS issue), File Browser overlay missing caption label

For XenForo 2.x, two buttons on the edit page appear slightly out of vertical alignment (a couple of pixels too low). The buttons are:

New Attachment (File browser overlay)
New Category (Create/edit page, below main editor)

These two buttons have the CSS class vw-search-button applied to them which causes the alignment issue. This class has the following rules:

Code:

.vw-search-button.button--cta { line-height: @_vwsearch-height; height: @_vwsearch-height; padding: 0; }

These buttons look fine without the vw-search-button class, so perhaps it might be better to just not apply this class to them? With these buttons converted to input groups, overall this is a great improvement and more consistent with core XF2 - top stuff!

----------

Also related to the File Browser overlay:
In "File Display Options", the textarea (vw-attach-desc) is currently missing a label (or placeholder) phrase. IIRC, this used to say "Caption"

Issue Details

Issue Number 5797

Issue Type Bug

Project VaultWiki 4.x Series

Category Styling / CSS

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.0 Beta 2

Fixed Version 4.1.0 Beta 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 15, 2019 1:48 PM

pegasus

VaultWiki Team

The .vw-search-button.button--cta rule was added to fix issues that occur on many custom styles that have increased the size of .button--cta elements, so that the button still fits in the input-group. However, it looks like more recent versions of XenForo 2.1 don't need the line-height part of the rule anymore, since .button is now a flex element. So in the next release, line-height will only be included for XenForo 2.0 (not 2.1).

Fixed the missing Caption label in the next release.

Reply

+ Reply

All times are GMT -4. The time now is 3:46 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 2] Editing pages: New Attachment/Category buttons slightly off-center vertically (trivial CSS issue), File Browser overlay missing caption label

Issue Tools