[4.1 Beta 1] Watched wiki content: checkbox alignment issue due to empty list element, block-outer bottom page navigation padding incorrect due to missing class
I've noticed a couple of minor styling issues on the watched wiki content page for XF2.
1) An extra (empty) list item in structItem-extraInfo throws the js-chooseItem checkbox out of alignment. This occurs when the notification preference is "Alerts only" (empty label). When this preference is Instant/Daily/Weekly email, the alignment is perfect.
URL:
https://www.vaultwiki.org/xf/index.php?wiki-watch/
For "Alerts only":
Code:
<ul class="structItem-extraInfo">
<li></li>
<li><label class="iconic iconic--noLabel"><input name="deletebox[1][893]" value="893" class="js-chooseItem" type="checkbox"><i aria-hidden="true"></i></label></li>
</ul>
The solution would be to not render this extra list item when there is no additional label to display. I've looked at the VW templates and I believe this was already your intention. I think this doesn't happen because a variable is always defined (in vw_subscribe_listbit) and then a subsequent condition (in vw_content_listbit) doesn't then check whether this variable is not empty.
vw_subscribe_listbit for reference:
Code:
<xf:set var="$extraInfo"><xf:if is="{$item.notifytype}">{$item.notification|raw}</xf:if></xf:set>
In template
vw_content_listbit, perhaps the below change will do?
Find:
Code:
<xf:if is="{$extraInfo}">
<li>{$extraInfo|raw}</li>
</xf:if>
Replace with:
Code:
<xf:if is="$extraInfo is not empty">
<li>{$extraInfo|raw}</li>
</xf:if>
-------
2) There is also a top/bottom padding issue with the bottom page navigation. The second
block-outer element is simply missing the additional
block-outer--after class in template
vw_subscribe_list.