Issue: [4.1 Beta 2] Member profile: Skip wiki stats if contributions/comments are 0. View all contributions by Array and missing phrase

Issue Tools
- View Changes

August 6, 2019 3:36 PM
ACL

Regular Member
[4.1 Beta 2] Member profile: Skip wiki stats if contributions/comments are 0. View all contributions by Array and missing phrase

XFMG only adds itself to a member's profile stats section when they have submitted 1+ media items:

Code:

<xf:if is="$user.xfmg_media_count"> <xf:if>

XFRM also implements this approach. If a user's resource count is 0 then the XFRM stat pair is skipped when viewing their member details.

I suggest that VaultWiki in the template vw_profile_ministats should do the same.

For wiki comments:

Code:

<xf:if is="$user.vwUserCount.vw_comments"> <dl class="pairs pairs--rows pairs--rows--centered"> <dt title="{{ vw_phrase('vw_profile_comments')|for_attr }}">{{ vw_phrase('vw_profile_comments') }}</dt> <dd> <a href="{{ link('search/member', null, {'user_id': $user.user_id, 'content': 'vwcomment'}) }}" class="fauxBlockLink-linkRow u-concealed"> {$user.vwUserCount.vw_comments|number} </a> </dd> </dl> </xf:if>

----

In the "Find" menu of a user profile, there is a menu item with the text "View all contributions by Array". In the template vw_profile_find_links, the phrase should be corrected to:

Code:

{{ vw_phrase('vw_profile_all_contribs', {$user.username}) }}

Also, I think in a profile context this phrase would make more sense to people if it explicitly said 'wiki contributions'.

----

At the path wiki/Special:Contributions?userid=1 , there is a missing phrase #!-- XEN:VWPHRASE vw_special_main_desc ARGS(Contributions) --#.

Beneath the missing phrase, the page then says: "This page description was added automatically because the current page has no text content. Edit this page to add more relevant text." This seems inconsistent with other special pages that do not show this message.

Issue Details

Issue Number 5816

Issue Type Bug

Project VaultWiki 4.x Series

Category User Profiles

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.0 Beta 2

Fixed Version (none)

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 9, 2019 3:23 PM

ACL

Regular Member

Additionally, for Special:Contributions for a user, the timestamp for recent edits may overflow out of the vw-history-list.

Example: https://www.vaultwiki.org/xf-wiki/in...tions?userid=1 - here the timestamp for the edits in August currently also includes the day of the week when there is no room for it.

On the Special:RecentEdits page, just the time is displayed without the day of week: https://www.vaultwiki.org/xf-wiki/in...al:RecentEdits

Reply
August 9, 2019 4:01 PM

pegasus

VaultWiki Team

Fixed some special pages incorrectly displaying the empty-text notice in the next build.

Fixed the "Array" phrase and improved consistency of the stat display with XF first-party add-ons in the next release.

Reply

+ Reply

All times are GMT -4. The time now is 3:47 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Beta 2] Member profile: Skip wiki stats if contributions/comments are 0. View all contributions by Array and missing phrase

Issue Tools