Issue: [4.1 Alpha 3] Admin cp: Area manager permissions legend not implemented, missing breadcrumb phrases, remove action overlay structure/styling

Issue Tools
- View Changes

May 3, 2019 12:37 PM
ACL

Regular Member
[4.1 Alpha 3] Admin cp: Area manager permissions legend not implemented, missing breadcrumb phrases, remove action overlay structure/styling

1) When viewing the usergroup permissions for a specific area, there is no colour-coding despite the "Key:" footnote saying so. If it is intended to add the colour coding, might I suggest that you utilize XenForo 2.x's existing CSS classes as used in Templates, Node permissions etc. What I mean is, for a customised usergroup, set the <tr> classes to:

Code:

class="dataList-row dataList-row--custom"

And for parent customised usergroup, set the classes to:

Code:

class="dataList-row dataList-row--parentCustom"

This would make this page more consistent with XenForo and cut-down on extra CSS

--

2) Missing phrase in the breadcrumb: #!-- XEN:VWPHRASE vw_structures_area_permissions ARGS() --#

Issue Details

Issue Number 5737

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status In Progress

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.0 Alpha 3

Fixed Version (none)

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

May 4, 2019 7:51 AM
ACL

Regular Member
3) "Removing Custom Permissions for: X" dialog has a few issues:

Missing breadcrumb phrase #!-- XEN:VWPHRASE vw_permissions_custom ARGS() --#
The "Yes" / "No" button labels could be more specific. E.g. "Delete" / "Cancel".
The "No" button points to the default wiki permissions link. To be honest, you could probably do away with this button, as it is already possible to cancel the overlay with the 'X' button or by clicking anywhere outside of the overlay.
The HTML structure is not quite right, resulting in a double border between the inforow and submitrow. Please check the standard XF template "undelete_confirm" for reference. The form element should have the "block" class. There is a missing div with "block-body" class. The inforow is not defined as rowtype="confirm" (class formInfoRow--confirm). The submit row is not defined as rowtype="simple" (class formSubmitRow--simple).

Also see my attached mockup which aims to improve the UX of this overlay. It emphasises which area the confirm action relates to, and is styled more like XenForo's standard prompts. A similar change is suggested for the Area remove prompt.
Reply
May 6, 2019 12:38 PM

pegasus

VaultWiki Team

1 & 2 are fixed in the next release.
For #3, some improvements were made to the HTML structure and buttons in the next release.

In another release, we may make some confirm overlay text more consistent with XenForo confirm overlays.

Reply

+ Reply

All times are GMT -4. The time now is 2:39 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Alpha 3] Admin cp: Area manager permissions legend not implemented, missing breadcrumb phrases, remove action overlay structure/styling

Issue Tools