Issue: [4.1 Alpha 3] Reactions: 1) encoded & in &do=likes URL, 2) no permission error, 3) like/unlike exceptions when opened in new tab

Issue Tools
- View Changes

March 21, 2019 9:10 AM

ACL

Regular Member

[4.1 Alpha 3] Reactions: 1) encoded & in &do=likes URL, 2) no permission error, 3) like/unlike exceptions when opened in new tab

1) Encoded & in view reactions URL

Path: index.php?wiki/&title=Testing-playground-for-XF2
(see reactionsBar)

Code:

https://www.vaultwiki.org/xf-wiki/index.php?wiki/=&amp;title=Testing-playground-for-XF2&amp;do=likes

2) No permission error on real view reactions URL

Path: index.php?wiki/&title=Testing-playground-for-XF2&do=likes

3) XF\Mvc\Reply\Exception

Path: index.php?wiki/&title=TOC-Nesting&do=like
(after adding/removing a reaction in a new tab, VW points to this URL instead of returning to the main wiki page)

When reacting: (does not happen when reaction_id is specified)

Code:

    XF\Mvc\Controller->exception()
    call_user_func_array() in src/XF/ControllerPlugin/AbstractPlugin.php at line 79
    XF\ControllerPlugin\AbstractPlugin->__call() in src/XF/ControllerPlugin/Reaction.php at line 100
    XF\ControllerPlugin\Reaction->actionToggleReaction() in src/XF/ControllerPlugin/Reaction.php at line 19
    XF\ControllerPlugin\Reaction->actionReact() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 58
    vw_Proxy_Like_Controller_XF2->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/base/vw.php at line 59
    vw_Proxy_Like_base_Controller->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/page/vw.php at line 20
    vw_Proxy_Like_Page_Controller->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 45
    vw_Proxy_Like_Controller_XF2->perform_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/vw.php at line 84
    vw_Proxy_Like_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 1324
    vw_UI_Page_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 282
    vw_UI_Page_Controller->execute() in /home/vw/edge/upload/vault/core/controller/ui/stack/vw.php at line 256
    vw_UI_Stack_Controller->execute() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/Wiki.php at line 75
    vw\vw\Pub\Controller\Wiki\Wiki->_actionIndex() in /home/vw/edge/upload/src/addons/vw/vw/Mvc/Dispatcher.php at line 25
    vw\vw\Mvc\Dispatcher::dispatch() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/AbstractController.php at line 21
    vw\vw\Pub\Controller\Wiki\AbstractController->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
    XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
    XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
    XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
    XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
    XF\App->run() in src/XF.php at line 390
    XF::runApp() in index.php at line 20

And removing a reaction: (does not happen when reaction_id is specified)

Code:

    XF\Mvc\Controller->exception()
    call_user_func_array() in src/XF/ControllerPlugin/AbstractPlugin.php at line 79
    XF\ControllerPlugin\AbstractPlugin->__call() in src/XF/ControllerPlugin/Reaction.php at line 100
    XF\ControllerPlugin\Reaction->actionToggleReaction() in src/XF/ControllerPlugin/Reaction.php at line 19
    XF\ControllerPlugin\Reaction->actionReact() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 58
    vw_Proxy_Like_Controller_XF2->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 99
    vw_Proxy_Like_Controller_XF2->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/base/vw.php at line 64
    vw_Proxy_Like_base_Controller->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/page/vw.php at line 68
    vw_Proxy_Like_Page_Controller->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 35
    vw_Proxy_Like_Controller_XF2->perform_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/vw.php at line 84
    vw_Proxy_Like_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 1324
    vw_UI_Page_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 282
    vw_UI_Page_Controller->execute() in /home/vw/edge/upload/vault/core/controller/ui/stack/vw.php at line 256
    vw_UI_Stack_Controller->execute() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/Wiki.php at line 75
    vw\vw\Pub\Controller\Wiki\Wiki->_actionIndex() in /home/vw/edge/upload/src/addons/vw/vw/Mvc/Dispatcher.php at line 25
    vw\vw\Mvc\Dispatcher::dispatch() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/AbstractController.php at line 21
    vw\vw\Pub\Controller\Wiki\AbstractController->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
    XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
    XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
    XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
    XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
    XF\App->run() in src/XF.php at line 390
    XF::runApp() in index.php at line 20

4) And when reacting via the XF reaction tooltip: json_decode() expects parameter 1 to be string, array given in /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php on line 125

The reaction is still saved/deleted, as manually refreshing the page shows the updated reactions in reactionsBar.

Code:

PHP: 
An exception occurred: [ErrorException] [E_WARNING] json_decode() expects parameter 1 to be string, array given in /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php on line 125
#0 [internal function]: XF::handlePhpError(2, '[E_WARNING] jso...', '/home/vw/edge/u...', 125, Array)
#1 /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php(125): json_decode(Array, true)
#2 src/XF/Mvc/Entity/Entity.php(148): vw\vw\XF\Entity\Entity->getReactions()
#3 src/XF/Mvc/Entity/Entity.php(101): XF\Mvc\Entity\Entity->get('reactions')
#4 src/XF/Template/Templater.php(3252): XF\Mvc\Entity\Entity->__get('reactions')
#5 [internal function]: XF\Template\Templater->fnReactions(Object(vw\vw\XF\Template\Templater), false, Object(vw_DM_Page_Controller_XF2), 'https://www.vau...')
#6 src/XF/Template/Templater.php(915): call_user_func_array(Array, Array)
#7 src/XF/Pub/View/Reaction/React.php(16): XF\Template\Templater->fn('reactions', Array)
#8 src/XF/Mvc/Renderer/AbstractRenderer.php(91): XF\Pub\View\Reaction\React->renderJson()
#9 src/XF/Mvc/Renderer/Json.php(63): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('XF:Reaction\\Rea...', '', Array)
#10 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('XF:Reaction\\Rea...', '', Array)
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}

Issue Details

Issue Number 5678

Issue Type Bug

Project VaultWiki 4.x Series

Category User Alerts / Likes

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 Alpha 3

Fixed Version 4.1.0 Alpha 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 21, 2019 9:20 AM

ACL

Regular Member

Also, in index.php?account/preferences , several of the VaultWiki opt-out phrases refer to likes instead of reactions.

Reply
March 21, 2019 11:25 AM

pegasus

VaultWiki Team

#1-4 fixed in the next build.

account/preferences phrases updated in the next release.

Reply
March 21, 2019 11:41 AM

ACL

Regular Member

Awesome, thanks!

Now that 2) is fixed, this reveals a missing phrase for the reactions list page title:
#!-- XEN:VWPHRASE vw_page_reactions ARGS() --#

And one other issue, the reactionsBar does not update without a page refresh. For standard Xenforo content types, the reacting user's username is added/removed from the bar. I think this could just be a simple missing s in the reactionsBar classes (bold emphasis mine):
<div class="reactionsBar js-reactionsList is-active">

Reply
March 22, 2019 10:12 AM

pegasus

VaultWiki Team

Phrases fixed in the next release.

missing s in classname fixed in build 002.

Reply

+ Reply

All times are GMT -4. The time now is 11:27 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Alpha 3] Reactions: 1) encoded &amp; in &do=likes URL, 2) no permission error, 3) like/unlike exceptions when opened in new tab

Issue Tools

Issue: [4.1 Alpha 3] Reactions: 1) encoded & in &do=likes URL, 2) no permission error, 3) like/unlike exceptions when opened in new tab