[4.1 Alpha 3] Reactions: 1) encoded & in &do=likes URL, 2) no permission error, 3) like/unlike exceptions when opened in new tab
1)
Encoded & in view reactions URL
Path: index.php?wiki/&title=Testing-playground-for-XF2
(see reactionsBar)
Code:
https://www.vaultwiki.org/xf-wiki/index.php?wiki/=&title=Testing-playground-for-XF2&do=likes
2)
No permission error on real view reactions URL
Path: index.php?wiki/&title=Testing-playground-for-XF2&do=likes
3)
XF\Mvc\Reply\Exception
Path: index.php?wiki/&title=TOC-Nesting&do=like
(after adding/removing a reaction in a new tab, VW points to this URL instead of returning to the main wiki page)
When reacting: (does not happen when reaction_id is specified)
Code:
XF\Mvc\Controller->exception()
call_user_func_array() in src/XF/ControllerPlugin/AbstractPlugin.php at line 79
XF\ControllerPlugin\AbstractPlugin->__call() in src/XF/ControllerPlugin/Reaction.php at line 100
XF\ControllerPlugin\Reaction->actionToggleReaction() in src/XF/ControllerPlugin/Reaction.php at line 19
XF\ControllerPlugin\Reaction->actionReact() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 58
vw_Proxy_Like_Controller_XF2->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/base/vw.php at line 59
vw_Proxy_Like_base_Controller->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/page/vw.php at line 20
vw_Proxy_Like_Page_Controller->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 45
vw_Proxy_Like_Controller_XF2->perform_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/vw.php at line 84
vw_Proxy_Like_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 1324
vw_UI_Page_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 282
vw_UI_Page_Controller->execute() in /home/vw/edge/upload/vault/core/controller/ui/stack/vw.php at line 256
vw_UI_Stack_Controller->execute() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/Wiki.php at line 75
vw\vw\Pub\Controller\Wiki\Wiki->_actionIndex() in /home/vw/edge/upload/src/addons/vw/vw/Mvc/Dispatcher.php at line 25
vw\vw\Mvc\Dispatcher::dispatch() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/AbstractController.php at line 21
vw\vw\Pub\Controller\Wiki\AbstractController->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
XF\App->run() in src/XF.php at line 390
XF::runApp() in index.php at line 20
And removing a reaction: (does not happen when reaction_id is specified)
Code:
XF\Mvc\Controller->exception()
call_user_func_array() in src/XF/ControllerPlugin/AbstractPlugin.php at line 79
XF\ControllerPlugin\AbstractPlugin->__call() in src/XF/ControllerPlugin/Reaction.php at line 100
XF\ControllerPlugin\Reaction->actionToggleReaction() in src/XF/ControllerPlugin/Reaction.php at line 19
XF\ControllerPlugin\Reaction->actionReact() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 58
vw_Proxy_Like_Controller_XF2->do_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 99
vw_Proxy_Like_Controller_XF2->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/base/vw.php at line 64
vw_Proxy_Like_base_Controller->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/page/vw.php at line 68
vw_Proxy_Like_Page_Controller->do_unlike() in /home/vw/edge/upload/vault/core/controller/proxy/like/xf2.php at line 35
vw_Proxy_Like_Controller_XF2->perform_like() in /home/vw/edge/upload/vault/core/controller/proxy/like/vw.php at line 84
vw_Proxy_Like_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 1324
vw_UI_Page_Controller->like() in /home/vw/edge/upload/vault/core/controller/ui/page/vw.php at line 282
vw_UI_Page_Controller->execute() in /home/vw/edge/upload/vault/core/controller/ui/stack/vw.php at line 256
vw_UI_Stack_Controller->execute() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/Wiki.php at line 75
vw\vw\Pub\Controller\Wiki\Wiki->_actionIndex() in /home/vw/edge/upload/src/addons/vw/vw/Mvc/Dispatcher.php at line 25
vw\vw\Mvc\Dispatcher::dispatch() in /home/vw/edge/upload/src/addons/vw/vw/Pub/Controller/Wiki/AbstractController.php at line 21
vw\vw\Pub\Controller\Wiki\AbstractController->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
XF\App->run() in src/XF.php at line 390
XF::runApp() in index.php at line 20
4) And when reacting via the XF reaction tooltip:
json_decode() expects parameter 1 to be string, array given in /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php on line 125
The reaction is still saved/deleted, as manually refreshing the page shows the updated reactions in reactionsBar.
Code:
PHP:
An exception occurred: [ErrorException] [E_WARNING] json_decode() expects parameter 1 to be string, array given in /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php on line 125
#0 [internal function]: XF::handlePhpError(2, '[E_WARNING] jso...', '/home/vw/edge/u...', 125, Array)
#1 /home/vw/edge/upload/src/addons/vw/vw/XF/Entity/Entity.php(125): json_decode(Array, true)
#2 src/XF/Mvc/Entity/Entity.php(148): vw\vw\XF\Entity\Entity->getReactions()
#3 src/XF/Mvc/Entity/Entity.php(101): XF\Mvc\Entity\Entity->get('reactions')
#4 src/XF/Template/Templater.php(3252): XF\Mvc\Entity\Entity->__get('reactions')
#5 [internal function]: XF\Template\Templater->fnReactions(Object(vw\vw\XF\Template\Templater), false, Object(vw_DM_Page_Controller_XF2), 'https://www.vau...')
#6 src/XF/Template/Templater.php(915): call_user_func_array(Array, Array)
#7 src/XF/Pub/View/Reaction/React.php(16): XF\Template\Templater->fn('reactions', Array)
#8 src/XF/Mvc/Renderer/AbstractRenderer.php(91): XF\Pub\View\Reaction\React->renderJson()
#9 src/XF/Mvc/Renderer/Json.php(63): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('XF:Reaction\\Rea...', '', Array)
#10 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('XF:Reaction\\Rea...', '', Array)
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}