Issue: XF2.1: Content sharing for section links (replace existing section link anchor)

Issue Tools
- View Changes

January 28, 2019 8:40 AM
ACL

Regular Member
XF2.1: Content sharing for section links (replace existing section link anchor)

XenForo 2.1 adds per-post content sharing options. This could be handy in VaultWiki too, for individual sections. The current anchor icon 'section link' is IMO cumbersome on mobiles as it requires fiddling around in the address bar. Changing this to XF2.1's content-sharing tool with the 'copy to clipboard' feature (and other social sharing options) would be helpful.

Details:
https://xenforo.com/community/thread...2/post-1291227

Originally Posted by XenForo.com

As well as being able to share directly to various social media outlets, you can also copy a link to the content directly to the clipboard.

What's better is that this share control is written in a fairly generic way so should add-on developers want to add this to their own add-ons it is very simple to do so.

Here's how the template side of things is setup for forum posts in post_macros template. The important bit is the "share-tooltop" element handler and the data-href parameter.

Code:

<a href="{{ link('threads/post', $thread, {'post_id': $post.post_id}) }}" data-xf-init="share-tooltip" data-href="{{ link('posts/share', $post) }}" rel="nofollow"> <xf:fa icon="fa-share-alt"/> </a>

Which calls the XF:Post controller's share action. And then XF\Pub\Controller\Post's actionShare calls \XF\ControllerPlugin\Share.

Thoughts/comments?

N.B. This feature suggestion is related to #5518 but different, as I'm talking about changes to VaultWiki section links, not the sidebar.

Unrelated: Also adjacent to the section link icon is the top link which duplicates stock XF2.0 functionality (please see my #5156 reply for details).

Issue Details

Issue Number 5609

Issue Type Feature

Project VaultWiki 4.x Series

Category Social Media

Status Implemented

Priority 7 - Minor Features / Enhancements

Suggested Version 4.1.0 Alpha 1 Public

Implemented Version 4.1.0 Alpha 3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Votes for this feature 1

Votes against this feature 0

Attachments 0

Assigned Users (none)

Tags (none)

March 11, 2019 1:08 PM

Alfa1

Distinguished Member

The 'anchor' link is outdated. XenForo 2.1 has a 'share' button with a sharing interface. One of the option is a anchor link. This works much better.
Please implement this for VW as well.

Reply
March 12, 2019 1:18 PM

pegasus

VaultWiki Team

Implemented in Alpha 3. In XenForo 2.1, the anchor link will open the sharing interface.

Reply
March 12, 2019 1:25 PM

ACL

Regular Member

Awesome .

In line with this XF2.1 change, it would be great to change the fa-anchor icon to fa-share-alt (f1e0), if you haven't already done so.

Reply
March 12, 2019 6:55 PM

Alfa1

Distinguished Member

Yes, please use fa-share-alt

Reply

+ Reply

All times are GMT -4. The time now is 2:36 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: XF2.1: Content sharing for section links (replace existing section link anchor)

Issue Tools