• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • [4.1 Alpha 2] Recent activity widget admin template error, different behaviour to Special:RecentChanges for moderated pages and timestamps

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: [4.1 Alpha 2] Recent activity widget admin template error, different behaviour to Special:RecentChanges for moderated pages and timestamps

    • Issue Tools
      • View Changes
    1. issueid=5647 February 14, 2019 1:35 PM
      ACL ACL is offline
      Regular Member
      [4.1 Alpha 2] Recent activity widget admin template error, different behaviour to Special:RecentChanges for moderated pages and timestamps

      1) The edit page for the Recent activity widget (and Live search) displays a template error:
      Code:
      Template admin:widget_edit: Declaration of vw_CP_Block_View::print_customized_controls($custom) should be compatible with vw_CP_Permission_View::print_customized_controls($controller, $custom) (src/addons/vw/vw/_core/view/cp/block/vw.php:15)
      2) When sending wiki pages back to the approval queue, there seems to be discrepencies with how Special:RecentChanges and the widget handle this. Looking at these pages from a wiki moderators (administrator) account:
      • Unapproving:
        • Special:RecentChanges: The "created this page" entry for the unapproved page is removed or hidden
        • Recent activity widget: The unapproved page remains in the widget list
      • Reapproving:
        • Special:RecentChanges: The "created this page" entry for the unapproved page is added back again with the original timestamp
        • Recent activity widget: The unapproved page is bumped to the top of the widget list with an updated timestamp



      The version history for the page I've placed into and back out of the approval queue says:
      38 minutes ago
      <username> created this Page
      Meanwhile in the Recent activity widget for the same wiki page:
      <username> created a new Page <title>
      15 minutes ago
      Bold emphasis is mine, with usernames and the page title snipped from this example.
    Issue Details
    Issue Number 5647
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Widgets / Sideblocks
    Status Fixed
    Priority 4 - Warnings / Script Errors
    Affected Version 4.1.0 Alpha 2
    Fixed Version 4.1.0 Beta 1
    Milestone (none)
    Software DependencyAny
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. February 16, 2019 3:44 AM
      ACL ACL is offline
      Regular Member
      Timestamps and user timezones:
      • Special:RecentChanges: These timestamps respect a User's timezone (set in XenForo account preferences). This is the desired behaviour.
      • Recent activity widget: These timestamps do not respect a user's timezone. Upon changing to a different timezone, the printed time is the same.


      For example, your latest edit to Wiki XF's index shows a timestamp of 4:31 PM in UTC and EST in the sidebar widget, whereas for Special:RecentChanges the timestamp will be different with non-UTC timezones.
      Reply Reply  
    2. February 21, 2019 4:06 PM
      pegasus pegasus is offline
      VaultWiki Team
      1) Should be fixed in build 002.

      2) This behavior difference is intentional since 4.1.0 Alpha 1.
      - The RecentChanges list is in historical order.
      - The activity widget is not intended to be historically accurate, but rather to constantly bump things that are active. The activity widget does not actually order the original content, but a different table where activity is tracked (vw_activity). Typically, this gains entries when content becomes visible, which in the case of approved content is not necessarily when the underlying content was posted. Multiple entries for the same content can stack in some cases, showing only one entry with the most recent activity time. This prevents a problem where moderated things that took a while to approve were already stale by the time they were approved (like if a moderator takes 2 months to approve it) and never got deserved attention in activity, per https://www.vaultwiki.org/issues/4269/

      As for the activity not using timezones, the bug was actually:
      When VaultWiki is active, all content (including non-wiki content) using XenForo's xf:date template syntax does not consider the user's time zone. Content that calculates the date using XenForo's language->date functions directly does consider the user's time zone. The result is an inconsistent calculation of times.

      This was due to a timing problem where VaultWiki was attempting to add callbacks to the XenForo templater before it was setup. This resulted in the templater getting instantiated before the XenForo language was setup (so no timezone yet) and inheriting the incomplete language settings.

      The timezone problem will be fixed in the next Alpha/Beta.
      Reply Reply  
    3. February 24, 2019 8:57 AM
      ACL ACL is offline
      Regular Member
      Thanks for fixing.

      Regarding 2), I can see merit for the widget order changes. However, I have the following comments:

      - If a page is placed back into the moderation queue, it would be helpful (for wiki moderators) if either the entry's icon was switched to vw-icon-mod (default red) or the entry is removed altogether. As-is, in my testing the icon is left as vw-icon-old, which could mislead one or more wiki moderators over the current moderation status of a certain wiki page.

      - Perhaps consider an admin option that would toggle between displaying the original revision timestamp and the approval timestamp. What I'm suggesting would only alter the displayed timestamp and not the order of the widget entries. It is just that if, for instance, someone edits a page in April 2018, but their edit isn't approved until June, having the phrase "X created a new Page ABC, June 2, 2018" isn't really true.
      Reply Reply  
    4. February 24, 2019 12:41 PM
      pegasus pegasus is offline
      VaultWiki Team
      For unapproval, in src/addons/vw/vw/_core/controller/dm/base/vw.php, find:
      Code:
      $deletes[$stream['contentid']] = $stream['contentid'];
      Replace with:
      Code:
      $deletes[$stream['activityid']] = $stream['activityid'];
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 3:22 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.