Issue: [4.1 Alpha 1] Unapproved content & queue: Several exceptions

Issue Tools
- View Changes

January 16, 2019 1:20 PM

ACL

Regular Member

[4.1 Alpha 1] Unapproved content & queue: Several exceptions

1. When attempting to view the approval queue with a wiki page pending review:
An exception occurred: [Error] Call to undefined method vw_CP_Mod_Page_View::description_row() in src/addons/vw/vw/Handler/ApprovalQueue/base.php on line 206

Code:

#0 src/XF/ApprovalQueue/AbstractHandler.php(72): vw\vw\Handler\ApprovalQueue\base->getTemplateData(Object(XF\Entity\ApprovalQueue))
#1 [internal function]: XF\ApprovalQueue\AbstractHandler->render(Object(XF\Entity\ApprovalQueue))
#2 src/XF/Template/Templater.php(940): call_user_func_array(Array, Array)
#3 internal_data/code_cache/templates/l1/s1/public/approval_queue.php(22): XF\Template\Templater->method(Object(vw\vw\Handler\ApprovalQueue\Page), 'render', Array)
#4 src/XF/Template/Templater.php(1250): XF\Template\Templater->{closure}(Object(vw\vw\XF\Template\Templater), Array)
#5 src/addons/vw/vw/XF/Template/Templater.php(621): XF\Template\Templater->renderTemplate('approval_queue', Array, true)
#6 src/XF/Template/Template.php(24): vw\vw\XF\Template\Templater->renderTemplate('public:approval...', Array)
#7 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#8 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:ApprovalQueu...', 'public:approval...', Array)
#9 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#11 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#12 src/XF.php(333): XF\App->run()
#13 index.php(13): XF::runApp('XF\\Pub\\App')
#14 {main}

2. When attempting to change the moderation status of an existing wiki page and send it back to the approval queue:
ErrorException: [E_WARNING] Missing argument 1 for vw_DM_Base_Controller::delete_stream(), called in /volume1/web/xf20wiki/src/addons/vw/vw/_core/controller/dm/page/vw.php on line 1714 and defined src/addons/vw/vw/_core/controller/dm/base/vw.php:2484

Code:

#0 src/addons/vw/vw/_core/controller/dm/base/vw.php(2484): XF::handlePhpError(2, '[E_WARNING] Mis...', '/volume1/web/xf...', 2484, Array)
#1 src/addons/vw/vw/_core/controller/dm/page/vw.php(1714): vw_DM_Base_Controller->delete_stream()
#2 src/addons/vw/vw/XF/Entity/Entity.php(574): vw_DM_Page_Controller->post_save_each()
#3 src/XF/Mvc/Entity/Entity.php(1165): vw\vw\XF\Entity\Entity->_postSave()
#4 src/addons/vw/vw/XF/Entity/Entity.php(501): XF\Mvc\Entity\Entity->save(false, false)
#5 src/addons/vw/vw/_core/controller/dm/xf2.php(363): vw\vw\XF\Entity\Entity->vwSave()
#6 src/addons/vw/vw/_core/controller/ui/imod/action/approve/vw.php(201): vw_DM_Controller_XF2->save()
#7 src/addons/vw/vw/_core/controller/ui/imod/action/approve/vw.php(164): vw_UI_iMod_Action_Approve_Controller->process_approve_generic(Array, Array)
#8 src/addons/vw/vw/_core/controller/ui/imod/action/base/vw.php(91): vw_UI_iMod_Action_Approve_Controller->perform_doapprove()
#9 src/addons/vw/vw/Handler/InlineMod/Base/AbstractAction.php(183): vw_UI_iMod_Action_base_Controller->process('doapprove')
#10 src/XF/InlineMod/AbstractAction.php(87): vw\vw\Handler\InlineMod\Base\AbstractAction->applyToEntity(Object(vw_DM_Page_Controller_XF2), Array)
#11 src/XF/InlineMod/AbstractAction.php(80): XF\InlineMod\AbstractAction->applyInternal(Object(XF\Mvc\Entity\ArrayCollection), Array)
#12 src/XF/Pub/Controller/InlineMod.php(131): XF\InlineMod\AbstractAction->apply(Object(XF\Mvc\Entity\ArrayCollection), Array)
#13 src/addons/vw/vw/XF/Pub/Controller/InlineMod.php(41): XF\Pub\Controller\InlineMod->actionPerform()
#14 src/XF/Mvc/Dispatcher.php(249): vw\vw\XF\Pub\Controller\InlineMod->actionPerform(Object(XF\Mvc\ParameterBag))
#15 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:InlineMod', 'Perform', 'json', Object(XF\Mvc\ParameterBag), '', Object(vw\vw\XF\Pub\Controller\InlineMod), NULL)
#16 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#17 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#18 src/XF.php(333): XF\App->run()
#19 index.php(13): XF::runApp('XF\\Pub\\App')
#20 {main}

3. This one may or may not be related to approval queue issues. Nevertheless, When attempting to view an area that contains a single wiki page pending moderation (and no approved/public pages) I get the below error. I have no issues viewing the default 'Wiki Pages' area that contains a few published pages (created by an admin account, bypassed approvial queue).

ErrorException: [E_NOTICE] Undefined offset: 7 in src/addons/vw/vw/_core/view/ui/area/vw.php at line 61

Code:

#0 src/addons/vw/vw/_core/view/ui/area/vw.php(61): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/volume1/web/xf...', 61, Array)
#1 src/addons/vw/vw/_core/view/reply/view/vw.php(48): vw_UI_Area_View->view(Array)
#2 src/addons/vw/vw/_core/view/reply/base/vw.php(134): vw_Reply_View_View->render_type('html')
#3 src/addons/vw/vw/_core/view/reply/stack/vw.php(44): vw_Reply_base_View->render('html')
#4 src/addons/vw/vw/XF/Mvc/View.php(25): vw_Reply_Stack_View->render('html')
#5 src/XF/Mvc/Renderer/AbstractRenderer.php(77): vw\vw\XF\Mvc\View->renderHtml()
#6 src/XF/Mvc/Renderer/Html.php(45): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('vw\\vw:Wiki', 'public:vw_gener...', Array)
#7 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('vw\\vw:Wiki', 'public:vw_gener...', Array)
#8 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#10 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#11 src/XF.php(333): XF\App->run()
#12 index.php(13): XF::runApp('XF\\Pub\\App')
#13 {main}

Issue Details

Issue Number 5597

Issue Type Bug

Project VaultWiki 4.x Series

Category Moderator Tools

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 Alpha 1 Public

Fixed Version 4.1.0 Alpha 1 Public

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 16, 2019 1:51 PM

ACL

Regular Member

#3 It is also worth mentioning that the third error (Undefined offset: 7) I don't see when viewing the same area as a standard user without moderator permissions. The area's page complete with default area text loads fine. But when loading the same link as an administrator, that's when I get this undefined offset error.

Reply
January 16, 2019 3:19 PM
pegasus

VaultWiki Team
1) In src/addons/vw/vw/Handler/ApprovalQueue/base.php, find:

Code:

$params['vwDescription'] = $this->vwBoater->description_row();

Replace with:

Code:

$params['vwDescription'] = $this->vwBoater->description();

2) In src/addons/vw/vw/_core/controller/dm/base/vw.php, find:

Code:

public function delete_stream($contentid)

Replace with:

Code:

public function delete_stream($contentid = 0)

3) This is not related to the approval queue. It looks like the area you are viewing is missing from the area tree. I would expect the area to not be visible from a parent area / index. If that's the case, we should try to figure out when the area was omitted from the area tree to make sure it isn't an unresolved bug. I am inclined to think that this will be another effect of the underlying issue here: https://www.vaultwiki.org/issues/5598/
Reply
January 16, 2019 5:31 PM

pegasus

VaultWiki Team

Confirmed #3 occurred due to the same issue in the Entity that was causing the comma-lists to be wrong.

1 & 2 are fixed, so marking this as fixed.

Reply

+ Reply

All times are GMT -4. The time now is 11:27 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Alpha 1] Unapproved content & queue: Several exceptions

Issue Tools