Issue: [4.1 Alpha 1] [wiki] bbcode unable to save page: LogicException: Cannot delete an entity that has been partially updated

Issue Tools
- View Changes

January 4, 2019 5:58 AM

ACL

Regular Member

[4.1 Alpha 1] [wiki] bbcode unable to save page: LogicException: Cannot delete an entity that has been partially updated

Whenever I attempt to save a page with manual [wiki]page name[/wiki] bbcode, a LogicException is generated. If I remove all instances of this bbcode and try saving the page, it saves successfully.

LogicException: Cannot delete an entity that has been partially updated in src/addons/vw/vw/XF/Entity/Entity.php at line 622

Stack trace:

Code:

vw\vw\XF\Entity\Entity->vwDelete() in src/addons/vw/vw/_core/controller/dm/xf2.php at line 390
vw_DM_Controller_XF2->delete() in src/addons/vw/vw/_core/controller/dm/batch/vw.php at line 110
vw_DM_Batch_Controller->save() in src/addons/vw/vw/_core/controller/dm/page/vw.php at line 2012
vw_DM_Page_Controller->save_links() in src/addons/vw/vw/_core/controller/dm/page/vw.php at line 1933
vw_DM_Page_Controller->save_revision() in src/addons/vw/vw/_core/controller/dm/page/vw.php at line 1555
vw_DM_Page_Controller->post_save_each() in src/addons/vw/vw/XF/Entity/Entity.php at line 565
vw\vw\XF\Entity\Entity->_postSave() in src/XF/Mvc/Entity/Entity.php at line 1165
XF\Mvc\Entity\Entity->save() in src/addons/vw/vw/XF/Entity/Entity.php at line 492
vw\vw\XF\Entity\Entity->vwSave() in src/addons/vw/vw/_core/controller/dm/xf2.php at line 362
vw_DM_Controller_XF2->save() in src/addons/vw/vw/_core/controller/ui/edit/vw.php at line 222
vw_UI_Edit_Controller->save() in src/addons/vw/vw/_core/controller/ui/page/vw.php at line 431
vw_UI_Page_Controller->save() in src/addons/vw/vw/_core/controller/ui/page/vw.php at line 166
vw_UI_Page_Controller->execute() in src/addons/vw/vw/_core/controller/ui/stack/vw.php at line 246
vw_UI_Stack_Controller->execute() in src/addons/vw/vw/Pub/Controller/Wiki/Wiki.php at line 80
vw\vw\Pub\Controller\Wiki\Wiki->_actionIndex() in src/addons/vw/vw/Mvc/Dispatcher.php at line 30
vw\vw\Mvc\Dispatcher::dispatch() in src/addons/vw/vw/Pub/Controller/Wiki/AbstractController.php at line 25
vw\vw\Pub\Controller\Wiki\AbstractController->actionIndex() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1934
XF\App->run() in src/XF.php at line 333
XF::runApp() in index.php at line 13

Issue Details

Issue Number 5578

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.0 Alpha 1 Public

Fixed Version 4.1.0 Alpha 1 Public

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 4, 2019 9:06 AM
ACL

Regular Member
I've tried this with the XF Demo wiki and the error is not occurring there: https://www.vaultwiki.org/xf-wiki/in...ground-for-XF2

But another BB-Code parsing is, which happens within my own XF2 VW 4.1 installation. [wiki] bbcode links with the optional link parameter, i.e. [wiki="page"][/wiki] , does not parse.

Another issue: " is being encoded in the Template HTML editor. This is rather annoying on pages that make use of bbcodes with parameters, such as wiki and H Example:

Code:

[wiki="Wiki XF"]link[/wiki] [H="3"]heading level 3[/H]
Reply
January 4, 2019 4:53 PM

pegasus

VaultWiki Team

Fixed the LogicException when saving pages containing links in the next build.

Fixed the installer creating certain BB-Codes without support for the BB-Code optional parameter. This might be fixed automatically during the upgrade to Alpha 2, but you can edit the affected BB-Codes manually and change the Optional Parameter setting from No to Optional.

Fixed the issue with editor contents becoming double-encoded when editing an existing page.

Reply
January 4, 2019 11:59 PM

ACL

Regular Member

Thank you.

Now that you mention the BBCode "Supports option parameter" XF setting, of course! Why didn't I think to look there... hah! I've altered this to 'optional' for now. If I remember prior to Alpha 2, I could change it back to 'no' and see whether the upgrade fixes it. But knowing me I'll forget

Reply

+ Reply

All times are GMT -4. The time now is 11:11 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1 Alpha 1] [wiki] bbcode unable to save page: LogicException: Cannot delete an entity that has been partially updated

Issue Tools