Issue: Auto-Linking not working

Issue Tools
- View Changes

December 9, 2017 11:39 AM

dvsDave

Regular Member

Auto-Linking not working

Running XF 1.5.14 and VW 4.0.20 Patch Level 1, only Manual links work, no auto-linking is working

Okay, I'm at a loss. Auto-linking isn't working at all. For example, In my Lighting & Electrics Forum, I have the node settings set to auto-link to our Wiki prefix (which has thousands of terms) .

For example, this thread has the word Selador in it: https://www.controlbooth.com/threads...istency.43135/

Wiki Term: https://www.controlbooth.com/wiki/Selador

I cleared the page cache, and our cloudflare cache and still cannot get the links to show up. No idea why it's not working.

Issue Details

Issue Number 5315

Issue Type Bug

Project VaultWiki 4.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.20

Fixed Version 4.0.21

Milestone (none)

Software DependencyvBulletin 4.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

December 9, 2017 12:19 PM

pegasus

VaultWiki Team

Did you check your global auto-link setting:
Options > VaultWiki: Wiki Links > Enable Auto-Links to Wiki Content

In 2015 you reported a similar issue and it was due to another add-on called "ParseHTML" which was not written correctly:
https://www.vaultwiki.org/issues/4409/#note24124
If you are using this add-on again, try disabling it.

Note also that the "Selador" page uses no prefix. If you set your auto-link setting to auto-link pages with the prefix "Wiki", "Selador" will not be autolinked because it uses no prefix, not "Wiki".

Reply
December 9, 2017 12:37 PM

dvsDave

Regular Member

Yes, the option is enabled. I am not using that addon. I have some forums that use No Prefix and some that have Wiki. Nothing is auto-linking, anywhere on my site except in the Wiki itself.

Reply
December 9, 2017 1:25 PM

pegasus

VaultWiki Team

The example you gave is not working because the autolink prefix does not match the term prefix. This is expected behavior.

In addition the term must have more characters than defined in Options > VaultWiki: Wiki Links > Minimum Characters for Auto-Links.
For example, if this setting is 4, then a term of "DVD" would not be autolinked to the "DVD" article, no matter what its prefix is.

Since you have more non-prefixed articles that are visible to me, please provide a new example which shows unexpected behavior:
- The name of a forum that has the autolink prefix set to No Prefix
- A post in that forum where a term is not autolinked
- The term in that post that should be autolinked

Reply
December 9, 2017 1:54 PM

dvsDave

Regular Member

Alright, can do.

Term is rosco (https://www.controlbooth.com/wiki/Rosco)

Forum is our Special Effects forum (set to No Prefix)

This post has the word rosco. https://www.controlbooth.com/threads...e-stage.42720/

and the word fog. https://www.controlbooth.com/wiki/fog

My settings are set to 3 character words or longer.

Reply
December 9, 2017 2:25 PM

pegasus

VaultWiki Team

Okay based on the information you've provided, it appears that this example is valid -- the term should be getting auto-linked and it is not. Since you've already checked all the settings that are related to this, and the issue seems consistent across user accounts (your account and me as a guest -- so is not likely related to the related user preference being missing from the form), but I cannot reproduce this issue on the demo running the same version, I would request that you open a new ticket for investigation, as this might be a new add-on conflict that I am not aware of: https://www.vaultwiki.org/members/?do=tickets

Reply
December 9, 2017 2:58 PM

dvsDave

Regular Member

I do use cloudflare, but I've been using it for 9 months. Is there a page rule I need to use to avoid caching something with vaultwiki to make sure auto-links works? It's the only other thing I can think of.

Reply

December 9, 2017 3:23 PM

pegasus

VaultWiki Team

I think I discovered the bug which may be causing this. It appears that the autolink forum setting was always being ignored in favor of the global setting Default Prefix for Auto-Links. The global setting is only supposed to take effect if there is no custom setting present.

It should be possible to correct this behavior by modifying vault/core/model/parser/handle/autolink/vw.php. Find:

Code:

// if nothing matched, fallback to default

Before it, add:

Code:

		else
		{
			$forum = false;

			if (is_numeric($this->forum))
			{
				$forumid = intval($this->forum);
				$forum = vw_Hard_Core::controller('Fetch')->get('Forum', $forumid);
			}
			else if (is_array($this->forum))
			{
				$forum = $this->forum;
			}

			if ($forum AND isset($forum['vw_autolink']))
			{
				if ($forum['vw_autolink'] == -1)
				{
					$this->disabled = true;
				}
				else if ($forum['vw_autolink'])
				{
					$prefix = vw_Hard_Core::controller('Fetch')->get('Prefix', $forum['vw_autolink']);

					if ($prefix)
					{
						return $prefix['prefixkey'];
					}

					$this->disabled = true;
				}

				return '';
			}
		}

December 9, 2017 5:11 PM

dvsDave

Regular Member

alright, that code has been updated. I'm not seeing any difference.

Reply
December 10, 2017 10:18 AM

pegasus

VaultWiki Team

I have updated the edit above to account for the various formats that $this->forum might appear in. After making/updating this edit on your site, you may need to clear your post cache (not the wiki one). To do this you generally need to change one of your BB-Codes. Since we are dealing with autolinks anyway, you can disable the autolink BB-Code, then re-enable it.

Once I identified what was causing the issue on your site, I was able to change my settings accordingly and reproduce it. The edit above has fixed the issue on my site. Marking this issue as fixed in the next release.

Reply
December 11, 2017 10:28 AM

dvsDave

Regular Member

Awesome. That did the trick! Thank you!

Reply

+ Reply

All times are GMT -4. The time now is 5:54 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Auto-Linking not working

Issue Tools