Issue: Convert threads To Wiki fails with database error (XF 1.5)

Issue Tools
- View Changes

October 6, 2017 4:34 AM

wolven

New Member

Convert threads To Wiki fails with database error (XF 1.5)

Trial to convert thread to wiki fails with database error

In Xenforo 1.5.15. it's impossible to convert threads to wiki content due to database error

Code:

ErrorException: Undefined variable: out - vault/core/model/image/metadata/gif/vw.php:101

array(3) {
  ["url"] => string(79) "https://www.txxxxxxx/forum/index.php?wiki-moderate/&do=processimport&task=15"
  ["_GET"] => array(3) {
    ["wiki-moderate/"] => string(0) ""
    ["do"] => string(13) "processimport"
    ["task"] => string(2) "15"
  }
  ["_POST"] => array(4) {
    ["_xfToken"] => string(8) "********"
    ["wiki-moderate/"] => string(0) ""
    ["do"] => string(13) "processimport"
    ["task"] => string(2) "15"
  }
}

0 /var/www/vhosts/xxxxxx/httpdocs/forum/vault/core/model/image/metadata/gif/vw.php(101): XenForo_Application::handlePhpError(8, 'Undefined varia...', '/var/www/vhosts...', 101, Array)
#1 /var/www/vhosts/xxxxxxx/httpdocs/forum/vault/core/model/image/metadata/vw.php(47): vw_Image_MetaData_GIF_Model->parse(Resource id #493)
#2 /var/www/vhosts/txxxxxx/httpdocs/forum/vault/core/model/image/vw.php(1508): vw_Image_Metadata_Model->__construct(Object(vw_Image_Structure_GIF_Model))
#3 /var/www/vhosts/txxxxxx/httpdocs/forum/vault/core/model/image/vw.php(404): vw_Image_Instance_Model->get_metadata(Object(vw_Image_Structure_GIF_Model))
#4 /var/www/vhosts/ttxxxxxx/httpdocs/forum/vault/core/model/image/vw.php(484): vw_Image_Instance_Model->init_metadata()
#5 /var/www/vhosts/ttxxxxxx/httpdocs/forum/vault/core/model/image/vw.php(616): vw_Image_Instance_Model->set_gd_info()
#6 /var/www/vhosts/txxxxxxx/httpdocs/forum/vault/core/controller/dm/attach/file/vw.php(955): vw_Image_Instance_Model->get_width()
#7 /var/www/vhosts/txxxxxu/httpdocs/forum/vault/core/controller/dm/attach/file/vw.php(237): vw_DM_Attach_File_Controller->set_dimensions()
#8 /var/www/vhosts/txxxxxx/httpdocs/forum/library/vw/XenForo/DataWriter.php(512): vw_DM_Attach_File_Controller->pre_save(true)
#9 /var/www/vhosts/txxxxxxx/httpdocs/forum/library/XenForo/DataWriter.php(1460): vw_XenForo_DataWriter->_preSave()
#10 /var/www/vhosts/txxxxxxx/httpdocs/forum/library/vw/XenForo/DataWriter.php(192): XenForo_DataWriter->preSave()
#11 /var/www/vhosts/ttxxxxxxu/httpdocs/forum/vault/core/controller/dm/xf.php(389): vw_XenForo_DataWriter->preSaveWithReturn()
#12 /var/www/vhosts/txxxxxx/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php(1866): vw_DM_Controller_XF->pre_save()
#13 /var/www/vhosts/txxxxxxx/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php(1762): vw_Import_Handle_Internal_Controller->create_wiki_attachment(Array, Array)
#14 /var/www/vhosts/txxxxxxxu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php(679): vw_Import_Handle_Internal_Controller->do_page_attachments(Array, Array)
#15 /var/www/vhosts/ttxxxxxxx/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php(653): vw_Import_Handle_Internal_Controller->process_link_page(Array)
#16 /var/www/vhosts/txxxxxxu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php(618): vw_Import_Handle_Internal_Controller->process_target_links('page', Array)
#17 /var/www/vhosts/txxxxxxxx/httpdocs/forum/vault/core/controller/import/steps/internal/vw.php(302): vw_Import_Handle_Internal_Controller->do_links('thread', 'page', Array, 0)
#18 /var/www/vhosts/xxxxxxxu/httpdocs/forum/vault/core/model/cron/deferred/import/vw.php(110): vw_Import_Steps_Internal_Controller->{closure}('thread', 'page', Array, 0)
#19 /var/www/vhosts/ttxxxxxxu/httpdocs/forum/vault/core/controller/ui/imod/vw.php(1002): vw_Cron_Deferred_Import_Model->run(Array)
#20 /var/www/vhosts/xxxxxx/httpdocs/forum/vault/core/controller/ui/imod/vw.php(52): vw_UI_iMod_Controller->process_import()
#21 /var/www/vhosts/txxxxxxu/httpdocs/forum/library/vw/XenForo/ControllerPublic/Wiki/Moderate.php(51): vw_UI_iMod_Controller->execute()
#22 /var/www/vhosts/txxxxxxxu/httpdocs/forum/library/XenForo/FrontController.php(351): vw_XenForo_ControllerPublic_Wiki_Moderate->actionIndex()
#23 /var/www/vhosts/txxxxxxx/httpdocs/forum/library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#24 /var/www/vhosts/txxxxxxx/httpdocs/forum/index.php(13): XenForo_FrontController->run()
#25 {main}

Issue Details

Issue Number 5263

Issue Type Bug

Project VaultWiki 4.x Series

Category Forum Posts / Non-Wiki Content

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.0.19

Fixed Version 4.0.20

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags database, xenforo

October 6, 2017 9:26 AM
pegasus

VaultWiki Team
The error you reported is not a database error. If this error prevented the conversion, then you are running debug mode which is not recommended for beta functions such as the thread converter. This error only occurs when converting a thread that has a GIF attached to the first post, and this error does not prevent the conversion if debug mode is off.

In vault/core/model/image/metadata/gif/vw.php, find:

Code:

foreach ($chunks AS $arr_offset => $chunk)

Before it, add:

Code:

$out = array();
Reply

This petition for a change to Won't Fix was rejected

October 12, 2017 10:33 AM

wolven

New Member

OK, I've tried it and did as you proposed, then I took the debug mode off, tired it again and received That:

Code:

An exception occurred: Call to a member function resizable() on null in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/dm/attach/file/vw.php on line 998

    vw_DM_Attach_File_Controller->set_dimensions() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/dm/attach/file/vw.php at line 237
    vw_DM_Attach_File_Controller->pre_save() in vw/XenForo/DataWriter.php at line 512
    vw_XenForo_DataWriter->_preSave() in XenForo/DataWriter.php at line 1460
    XenForo_DataWriter->preSave() in vw/XenForo/DataWriter.php at line 192
    vw_XenForo_DataWriter->preSaveWithReturn() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/dm/xf.php at line 389
    vw_DM_Controller_XF->pre_save() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php at line 1866
    vw_Import_Handle_Internal_Controller->create_wiki_attachment() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php at line 1762
    vw_Import_Handle_Internal_Controller->do_page_attachments() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php at line 679
    vw_Import_Handle_Internal_Controller->process_link_page() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php at line 653
    vw_Import_Handle_Internal_Controller->process_target_links() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/handle/internal/vw.php at line 618
    vw_Import_Handle_Internal_Controller->do_links() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/import/steps/internal/vw.php at line 302
    vw_Import_Steps_Internal_Controller->{closure}() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/model/cron/deferred/import/vw.php at line 110
    vw_Cron_Deferred_Import_Model->run() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/ui/imod/vw.php at line 1002
    vw_UI_iMod_Controller->process_import() in /var/www/vhosts/tt-board.eu/httpdocs/forum/vault/core/controller/ui/imod/vw.php at line 52
    vw_UI_iMod_Controller->execute() in vw/XenForo/ControllerPublic/Wiki/Moderate.php at line 51
    vw_XenForo_ControllerPublic_Wiki_Moderate->actionIndex() in XenForo/FrontController.php at line 351
    XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 134
    XenForo_FrontController->run() in /var/www/vhosts/tt-board.eu/httpdocs/forum/index.php at line 13

any suggestions?

October 12, 2017 11:19 AM
pegasus

VaultWiki Team
We are aware of and have already fixed this issue in the current ZIP. It was due to a bad merge of the patch code. You can correct the issue by modifying /vault/core/controller/dm/attach/file/vw.php. Find and remove:

Code:

if (!$resource->resizable()) { $error = vw_Hard_Core::view('Phrase')->get('vw_exceed_width_error', 'error'); $error = vw_Hard_Core::view('Phrase')->sprintf($error, $this->filetype['width']); $this->instance->error($error); return false; }

However, I recommend that you redownload 4.0.19 PL 2 instead, as it already contains some other fixes, such as performance issues in handling of JPEG files.
Reply

+ Reply

All times are GMT -4. The time now is 9:34 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Convert threads To Wiki fails with database error (XF 1.5)

Issue Tools