Issue: Browser hangs at upgrade

Issue Tools
- View Changes

August 23, 2017 10:33 PM

Alfa1

Distinguished Member

Browser hangs at upgrade

The step to update wiki contributors for all edits/members of my big board takes hours. The Firefox browser consumes multiple GBs and then hangs.

Issue Details

Issue Number 5198

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.19

Fixed Version 4.0.19

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 24, 2017 10:05 AM
pegasus

VaultWiki Team
There are 18 steps in the upgrade and 16 of them are dedicated to updating contributor information, but I think I can guess which steps gave you trouble. If you have 200K contributors, it is feasible that each step could take 3 hours; most of this is a bottleneck due to latency of the repeated HTTP requests. If you have a high PHP timeout timeout, you might be able to speed this up close to 20x (by reducing latency) with some edits:

In vault/install/lib/upgradepath/steps/4/0/19/base/vw.php, find:

Code:

$counter->set_limits();

Replace with:

Code:

$counter->set_limits(5000);

Find:

Code:

if ($output['url'] != $empty_url) { $caller->offset += 200;

Replace with:

Code:

if ($output['url'] != $empty_url) { $caller->offset += 5000;

This pattern repeats for a number of steps. Some steps use a slightly different pattern for the second edit:

Code:

if ($batch) { $caller->offset += 200;

Replace with:

Code:

if ($batch) { $caller->offset += 5000;

It is worth noting that I rarely use Firefox anymore as it tends to have memory leaks for the past several years. I would not expect the VaultWiki installer to use that much memory unless there are several million entries in the progress window. Even if the installer was stuck in an infinite loop for 3 hours, running once per second, I would not expect it to use more than 4 MBs.
Reply
August 24, 2017 10:24 AM

Alfa1

Distinguished Member

I hear you about Firefox. I do not want to add my browser data to the Google matrix, so Chrome is out of the question.

Reply
August 24, 2017 5:28 PM

Alfa1

Distinguished Member

It runs better now, but after 6-7 hours or so on 1% it hangs again.

Reply
August 25, 2017 10:27 AM

pegasus

VaultWiki Team

Perhaps I am looking at tweaking the wrong step. As 1% is relative, please provide the Step number and step description that appears in the progress window, or PM me to run the upgrade script myself so I can see what bit it's hanging on.

Reply
August 26, 2017 10:24 AM

pegasus

VaultWiki Team

When there were more than 2000 unique contributing users, it was possible for the upgrade script to get stuck in a loop, which is what happened here. I have corrected the issue on your test site, and the upgrade finished within minutes (rather than hours). I am posting the changes as build 002 now.

Reply

+ Reply

All times are GMT -4. The time now is 3:29 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Browser hangs at upgrade

Issue Tools