• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • Search box should inherit XF classes

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Search box should inherit XF classes

    • Issue Tools
      • View Changes
    1. issueid=5157 July 11, 2017 10:35 AM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Search box should inherit XF classes

      The categories search box on &do=edit should inherit style properties from XenForo, so that things like borders and margin are inherited.
    Issue Details
    Issue Number 5157
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Styling / CSS
    Status Fixed
    Priority 7 - Minor Features / Enhancements
    Affected Version 4.0.18
    Fixed Version 4.0.19
    Milestone (none)
    Software DependencyXenForo 1.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. July 11, 2017 10:48 AM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Please see bug report 320871 on my site.
      Reply Reply  
    2. July 12, 2017 12:24 PM
      pegasus pegasus is offline
      VaultWiki Team
      Even if the search box in the form does inherit from XenForo's search box styles (which would be awkward in some cases because it is more like an auto-complete input field -- such as username inputs), it would not solve the issue here. In fact, the category-search container is already the same height as the navbar search container, yet the New Category button does not fit.

      In this case, the problem is that the "New Category" button inherits all of its properties from XenForo's .callToAction class (sizing, margins, etc). The solution to the problem in this case is to override the sizing provided by that class, as it will not always fit inside the input (even a search-clone input) if the callToAction sizes are used.
      Reply Reply  
    3. July 12, 2017 1:35 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      This is a hard one to solve. Normally pages to create new content do not have a sidebar and there is no space restriction of this kind.
      However, it still needs to be responsive.

      When you look at this interface with auto-complete drop down on the default style then it doesn't work / look well. There is a 'more' button floating partly outside the drop down. (see attachment)

      I do not follow the logic to override the default class to gain space. That doesn't seem proper.
      There is a sidebar on this page which has no purpose on a page to create a new page.

      When you decrease the width of this page (in default style) then 3 fields go outside the container and the autocomplete drop down is cuttoff.
      When I check out the styling then half of the button is overlapping the search box. This is the issue. The button should not overlap, but be next to the search box. And on narrow width move to the bottom responsively.

      I need the categories search box to get the appropriate border and styling similar to all XF fields.
      Similarly I need the calltoaction have the same styling as all other buttons in XF.

      If its not possible to inherit then there should be a style property so that its easy to adjust.
      Reply Reply  
    4. July 12, 2017 1:50 PM
      pegasus pegasus is offline
      VaultWiki Team
      In VaultWiki, the button is designed to be inside the search box, not next to it. The issue has nothing to do with sidebar or responsiveness or anything like that, but that the class for the button makes the button larger in height than the height of the class for the search box, resulting in the button overflowing outside the search box it is inside.

      There are only two ways to fix this: increase the height of the search box, or decrease the height of the button. Even if the button was next to the search box, rather than inside it, it would still look awkward if they were not the same height.

      I think that reducing button size is the best solution because:
      - Increasing the height of the search input would be inconsistent with every other input field on the page
      - The button does not have the same level of importance as other callToAction buttons or even other form controls on this tab (for example, Save Changes is actually smaller in size in your style), so it could stand to be muted in some way.
      Reply Reply  
    5. July 22, 2017 12:25 PM
      pegasus pegasus is offline
      VaultWiki Team
      Marking this as fixed in the next release.
      • Implemented the correct border and focus colors, from other XF text controls, on the VW live search fields by implementing the textCtrl class. We were able to do this, rather than duplicating textCtrl properties on the vw-search-container class, because the workaround we had in order to implement the placeholder attribute is not really necessary in XenForo, which has its own workaround for it. This allowed us to remove some unnecessary CSS.
      • Fixed the issue where the More... button was exceeding the drop-down height, by stretching the last row to accommodate the button.
      • For the +New buttons, we will dynamically change the height of the button and its interior font size based on the value of XenForo's existing textCtrl.height style property. For styles where this property is not defined (like the default style), a default value of 24px (the height that most stock inputs render in Chrome) will be assumed in order to perform the calculations.
      • Added a new responsive feature of the buttons: below the medium-width, only the + will be displayed.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 5:47 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.