Issue: Subscribed/watched icon in Xenforo Flat Awesome style shows as text

Issue Tools
- View Changes

March 28, 2017 4:46 PM

ACL

Regular Member

Subscribed/watched icon in Xenforo Flat Awesome style shows as text

The watched/subscribed icon is missing in the Xenforo version of VaultWiki when using Flat Awesome as the forum style. I've confirmed this also occurs with the XF wiki demo here at vaultwiki.org as well. In the default Xenforo style this icon comes from the xenforo-ui-sprite.png file.

Looking at the CSS I can see the parent class .vw-content-list-meta is set to use FontAwesome as the font family, however .vw-content-list-watched doesn't have any style rules for either a FontAwesome icon or the necessary background-image link to xenforo-ui-sprite.png (also included with Flat Awesome).

The other stickler is that the Flat Awesome style uses "fa-eye" to identify watched threads, yet this FA icon is already used by VaultWiki for another purpose (number of views). Using another FA icon for watched/subscribed like "fa-bell" would be inconsistent with Xenforo but at least that would avoid "fa-eye" being rendered on the same page to signify two very different meanings.

Issue Details

Issue Number 4969

Issue Type Bug

Project VaultWiki 4.x Series

Category Images / Icons

Status Not a Bug

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.0.17

Fixed Version (none)

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

March 28, 2017 5:09 PM

pegasus

VaultWiki Team

.vw-content-list-watched gets its style rules from XenForo's @DicussionListIcon style property (see vw_content_list.css), which in the default style sets up the xenforo-ui-sprite.png inclusion, but this is modified in Flat Awesome. It may be possible to detect a Flat Awesome style using the unique style properties that it has, such as fa_version, and to include changes in the default style, but for large numbers of custom styles, this could make the core template code become unruly and bloated for people who don't even use some styles.

This is not a bug in VaultWiki directly. In the future we may release a Flat Awesome style for VaultWiki templates, but as an add-on.

Until then, please make your desired custom edits to your style using VaultWiki's vw_additional.css template.

Reply
March 28, 2017 6:06 PM

ACL

Regular Member

Fair enough .

For something perhaps a bit more versatile, rather than focusing on Flat Awesome specifically perhaps you could consider an admin style setting checkbox for "Force FontAwesome icons" that would insert the necessary 'content: xyz' element:before css styling rules for any icons that otherwise rely on the xenforo-ui-sprite.png? Perhaps as a separate tab under Settings in the Wiki Icons group? As VaultWiki already includes the fontawesome files there'd be no need to restrict this to xenforo styles which use fontawesome.

Reply

+ Reply

All times are GMT -4. The time now is 11:25 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Subscribed/watched icon in Xenforo Flat Awesome style shows as text

Issue Tools