Issue: Discussion can not be deleted

Issue Tools
- View Changes

January 25, 2015 10:57 AM

hollosch

Senior Member

Discussion can not be deleted

I deleted the discussion in the ACP, but on the main page of the area it's still there!

Issue Details

Issue Number 4158

Issue Type Bug

Project VaultWiki 4.x Series

Category Discussions / Comments

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.0.0

Fixed Version 4.0.2

Milestone (none)

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

January 25, 2015 11:14 AM

pegasus

VaultWiki Team

What tool did you use to remove the discussion? There are multiple ways to do it. Perhaps that tool is not working correctly.

Reply
January 25, 2015 11:17 AM

hollosch

Senior Member

I deleted the discussion in the ACP

Reply
January 25, 2015 11:48 AM

pegasus

VaultWiki Team

There are at least 3 tools that I know of in the ACP where you can delete discussions. What ACP page was it on?

Reply
January 25, 2015 11:52 AM

hollosch

Senior Member

admin.php?wiki/topic

Reply
January 26, 2015 11:25 AM

pegasus

VaultWiki Team

Deleting discussions from wiki/topic will only remove empty copies of that discussion from wiki pages. If users already started posting in that discussion on 1 article, it will not be removed from that 1 article unless you manually remove it using inline moderation.

Reply
February 2, 2015 6:57 PM

hollosch

Senior Member

Don't work.

Reply
February 3, 2015 12:26 PM

pegasus

VaultWiki Team

Just tried it on XenForo. Had a topic called "Test Topic" in admin.php?wiki/topic. It showed in many areas.

I deleted it.
It no longer shows in those areas.

The delete confirmation very clearly explains that if the topic has some comments on a page, then it won't be removed from that page. It's possible that you commented on a topic before, but then deleted all the comments to make it empty again. This still will not be deleted by the global topic delete since it has had some activity already.

Thus, if you're still having a problem deleting discussions, then you are maybe using another method to delete discussions and you are not describing the problem well enough. You need to give a lot more information than "don't work".

I am reopening this bug simply because there is some confusion with the description of Discussion Topics in the Admin Panel. Instead, they should be called Topic Suggestions. Once a user takes the suggestion and creates the topic, removing the suggestion in the future will not remove topics that were based on the suggestion, even if the new topic is currently empty. It will just prevent more people from seeing the suggestion.

Suggestions and created topics also do not have different appearances, which is also a point of confusion. A suggestion should be marked "Suggested" or something like that.

Reply
February 3, 2015 1:40 PM

pegasus

VaultWiki Team

I think I know what you mean now. When viewing the discussion index, the previewed discussions list doesn't have inline moderation controls. These controls are only available in the full list view of the discussions list. However, if there are less than 5 discussions, there is no link to the full view. If you visit a discussion hoping for an alternative delete method, there is no delete link from within the discussion.

Additionally, there were a few bugs where:
- A discussion owner, without moderator permissions to delete discussions, but who has permission to delete his/her own discussions, would never be allowed to delete his own discussions.
- The checkbox to delete a discussion would only appear if a moderator had permission to delete his/her own comments.
- The checkbox to delete a discussion would never appear if the discussion was originally started from a topic suggestion.

Thus, there are numerous issues related to your OP that must be resolved by a new release.

In the mean time, you should be able to see the option to remove discussions by manually going to ?do=comments&action=list

Reply

February 3, 2015 5:22 PM

hollosch

Senior Member

Following errors occured while deleting via "?do=comments&action=list"

----------

Code:

ErrorException: Undefined index: accesskey - vault/core/controller/dm/base/vw.php:1007
Generiert durch: hollosch, Vor einer Minute
Stapelverfolgung
#0 /../vault/core/controller/dm/base/vw.php(1007): XenForo_Application::handlePhpError(8, 'Undefined index...', '/var/www/vhosts...', 1007, Array)
#1 /../vault/core/controller/dm/discussion/vw.php(286): vw_DM_Base_Controller->rebuild_lastupdate(5, Array, false)
#2 /../vault/core/controller/dm/vw.php(113): vw_DM_Discussion_Controller->delete_multiple(Array)
#3 /../vault/core/controller/ui/imod/vw.php(385): vw_DM_Controller->delete_multiple(Array)
#4 /../vault/core/controller/ui/imod/vw.php(108): vw_UI_iMod_Controller->kill()
#5 /../library/vw/XenForo/ControllerPublic/Wiki/Moderate.php(50): vw_UI_iMod_Controller->execute()
#6 /../library/XenForo/FrontController.php(347): vw_XenForo_ControllerPublic_Wiki_Moderate->actionIndex()
#7 /../library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#8 /../index.php(13): XenForo_FrontController->run()
#9 {main}
Benötigter Status
array(3) {
  ["url"] => string(44) "http://geislingen.net/wiki-moderate/?do=kill"
  ["_GET"] => array(1) {
    ["do"] => string(4) "kill"
  }
  ["_POST"] => array(6) {
    ["harddelete"] => string(1) "2"
    ["sbutton"] => string(8) "Continue"
    ["_xfToken"] => string(8) "********"
    ["do"] => string(4) "kill"
    ["url"] => string(51) "http://geislingen.net/wiki/?do=comments&action=list"
    ["items"] => array(1) {
      [5] => array(1) {
        [1] => string(1) "1"
      }
    }
  }
}
-----------

ErrorException: Undefined index: accesskey - vault/core/controller/dm/base/vw.php:998
Generiert durch: hollosch, Vor 3 Minuten
Stapelverfolgung
#0 /../vault/core/controller/dm/base/vw.php(998): XenForo_Application::handlePhpError(8, 'Undefined index...', '/var/www/vhosts...', 998, Array)
#1 /../vault/core/controller/dm/discussion/vw.php(286): vw_DM_Base_Controller->rebuild_lastupdate(5, Array, false)
#2 /../vault/core/controller/dm/vw.php(113): vw_DM_Discussion_Controller->delete_multiple(Array)
#3 /../vault/core/controller/ui/imod/vw.php(385): vw_DM_Controller->delete_multiple(Array)
#4 /../vault/core/controller/ui/imod/vw.php(108): vw_UI_iMod_Controller->kill()
#5 /../library/vw/XenForo/ControllerPublic/Wiki/Moderate.php(50): vw_UI_iMod_Controller->execute()
#6 /../library/XenForo/FrontController.php(347): vw_XenForo_ControllerPublic_Wiki_Moderate->actionIndex()
#7 /../library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#8 /../index.php(13): XenForo_FrontController->run()
#9 {main}
Benötigter Status
array(3) {
  ["url"] => string(44) "http://geislingen.net/wiki-moderate/?do=kill"
  ["_GET"] => array(1) {
    ["do"] => string(4) "kill"
  }
  ["_POST"] => array(6) {
    ["harddelete"] => string(1) "2"
    ["sbutton"] => string(8) "Continue"
    ["_xfToken"] => string(8) "********"
    ["do"] => string(4) "kill"
    ["url"] => string(51) "http://geislingen.net/wiki/?do=comments&action=list"
    ["items"] => array(1) {
      [5] => array(1) {
        [1] => string(1) "1"
      }
    }
  }
}

-----------

ErrorException: Undefined variable: feedtypeid - vault/core/controller/dm/base/vw.php:1837
Generiert durch: hollosch, Vor 3 Minuten
Stapelverfolgung
#0 /../vault/core/controller/dm/base/vw.php(1837): XenForo_Application::handlePhpError(8, 'Undefined varia...', '/var/www/vhosts...', 1837, Array)
#1 /../vault/core/controller/dm/discussion/vw.php(342): vw_DM_Base_Controller->affected_nodes(Array, false)
#2 /../vault/core/controller/dm/base/vw.php(924): vw_DM_Discussion_Controller->affected_nodes(Array, false)
#3 /../vault/core/controller/dm/discussion/vw.php(286): vw_DM_Base_Controller->rebuild_lastupdate(5, Array, false)
#4 /../vault/core/controller/dm/vw.php(113): vw_DM_Discussion_Controller->delete_multiple(Array)
#5 /../vault/core/controller/ui/imod/vw.php(385): vw_DM_Controller->delete_multiple(Array)
#6 /../vault/core/controller/ui/imod/vw.php(108): vw_UI_iMod_Controller->kill()
#7 /../library/vw/XenForo/ControllerPublic/Wiki/Moderate.php(50): vw_UI_iMod_Controller->execute()
#8 /../library/XenForo/FrontController.php(347): vw_XenForo_ControllerPublic_Wiki_Moderate->actionIndex()
#9 /../library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#10 /../index.php(13): XenForo_FrontController->run()
#11 {main}
Benötigter Status
array(3) {
  ["url"] => string(44) "http://geislingen.net/wiki-moderate/?do=kill"
  ["_GET"] => array(1) {
    ["do"] => string(4) "kill"
  }
  ["_POST"] => array(6) {
    ["harddelete"] => string(1) "2"
    ["sbutton"] => string(8) "Continue"
    ["_xfToken"] => string(8) "********"
    ["do"] => string(4) "kill"
    ["url"] => string(51) "http://geislingen.net/wiki/?do=comments&action=list"
    ["items"] => array(1) {
      [5] => array(1) {
        [1] => string(1) "1"
      }
    }
  }
}

February 3, 2015 5:23 PM

hollosch

Senior Member

Discussion now is deleted!

Reply
February 25, 2015 1:08 PM

pegasus

VaultWiki Team

Marking as fixed in the next release. In 4.0.2, there will be an X (for delete) next to the heading when reading user-generated discussions.

Reply

+ Reply

All times are GMT -4. The time now is 12:29 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Discussion can not be deleted

Issue Tools