Issue: CSS modifications are lost on each upgrade

Issue Tools
- View Changes

September 2, 2014 5:01 PM

Alfa1

Distinguished Member

CSS modifications are lost on each upgrade

Previously I noted that the extra css was lost on upgrade. IIRC you stated that this would only happen at that upgrade but not with subsequent upgrades. With the upgrade to RC2 this happened again. I also lost other style edits as my custom style has become undone for wiki.

Issue Details

Issue Number 3974

Issue Type Bug

Project VaultWiki 4.x Series

Category Styling / CSS

Status Duplicate

Priority 3 - Loss of Functionality

Affected Version 4.0.0 RC 2

Fixed Version (none)

Milestone VaultWiki 4.0 Gold

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 2, 2014 5:50 PM
pegasus

VaultWiki Team
The offending code that originally caused this:

Code:

vw_XenForo_Model::fetch('XenForo_Model_Template')->deleteTemplatesForAddOn('vaultwiki');

Is no longer present in vault/core/controller/install/common/xf.php
There is no other code that would result in any unwanted loss of template data.

If you are using an Opcode Cache like Zend Opcache, Xcache, etc, make sure that you always empty it before performing an upgrade, or you risk running the old code from the last version even though you already uploaded new files. Trusting the server to compare if a file is new or updated based on a timestamp is not reliable as mentioned in the manual page for Updating the VaultWiki Scripts on Your Web Server:

Make sure that you choose to overwrite ALL existing VaultWiki files with the files in the package. Some clients have options allowing you to only overwrite if timestamps are newer; avoid using this option.

Most opcode caches use a similar timestamp-comparison feature to determine if the cache is stale. If you KNOW the cache is stale, you should actively expire it.

You can confirm if it was a cache issue by following these steps:
1. Perform an innocuous, but easy to notice, template edit in a vaultwiki template.
2. Clear your opcode cache.
3. Visit the upgrade script and have it re-run the last upgrade.
4. Check if the template edit is still in effect, or if the control panel suggests a template is outdated.
Reply
September 23, 2014 11:42 AM

pegasus

VaultWiki Team

Confirmed that this issue does not exist in RC 2 by running the upgrade script while wiki templates had modifications. The edits were preserved after the upgrade completed (XF CP highlighted the template as customized, and viewing the source showed the previous customizations). Closing this issue as a Duplicate of the previously reported issue for RC 1.

Reply

+ Reply

All times are GMT -4. The time now is 11:21 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: CSS modifications are lost on each upgrade

Issue Tools